On Sun, Mar 10, 2013 at 04:13:50PM +0100, jolly wrote:
http://cgit.osmocom.org/cgit/openbsc/commit/?h=jolly/testing&id=f029472c...
* One should increase the version number of the MNCC protocol when adding new commands
* callref_keep.. maybe callref_orig or callref_kept * the printf for 32 vs. 33 can be fixed right now * msg_type == GSM_TCHF_FRAME || msg_type == GSM_TCHF_FRAME_EFR... maybe introduce a helper function is_audio_type(msg_type)
+ if (!trans->conn) { + LOGP(DMNCC, LOGL_NOTICE, "TCH frame for trans without conn\n"); + return 0; + } + if (trans->conn->lchan->type != GSM_LCHAN_TCH_F) {
At least with the BSC part it is possible to have subscriber connection with no lchan associated. You might want to add another null check for the lchan here.