Re: [libosmocore PATCH v2] src/socket: Adding domain socket support

On Sat, Mar 22, 2014 at 05:15:38PM +0100, Alvaro Neira Ayuso wrote:

+/*! \brief Initialize a domain socket (including bind/connect)

to follow unix(7) maybe call it UNIX domain socket

• • \param[in] type Socket type like SOCK_DGRAM, SOCK_STREAM
• • \param[in] proto Protocol like IPPROTO_TCP, IPPROTO_UDP

• • This function creates a new socket unix, \a

UNIX domain socket?

• if (flags & OSMO_SOCK_F_NONBLOCK) {

• if (ioctl(sfd, FIONBIO, (unsigned char *)&on) < 0) {
  

• 	perror("cannot set this socket unblocking");
  

• 	close(sfd);
  

• 	return -EINVAL;
  

• }
  

• }
• if (flags & OSMO_SOCK_F_BIND)

• listen(sfd, 10);
  

Do you want to check the return value of listen as well?

+/*! \brief Initialize a domain socket and fill \ref osmo_fd

UNIX domain socket

the actual code looks fine. Please fix the comments and send an updated patch. I would be happy to merge it tomorrow.