Patch Set 1: Code-Review+1
(1 comment)
It's all correct (compared visually).
Not sure if the whitespace is a reason to re-edit, so just +1 for now.
https://gerrit.osmocom.org/#/c/124/1/include/osmocom/gsm/protocol/gsm_04_08…
File include/osmocom/gsm/protocol/gsm_04_08.h:
Line 83: uint8_t form_id:5,
the whitespace pattern used above is "uint8_t<tab>w1_hi"
and then "<tab><space>f0".
I completely dislike the whitespace scheme used here anyway,
but this introduces yet another weird ws pattern ;)
(I do see that it follows from just swapping the lines)
--
To view, visit
https://gerrit.osmocom.org/124
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29eafe481e112d18c624b1c83add0d53c354dbe4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Ruben Undheim <ruben.undheim(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-HasComments: Yes