Re: [PATCH 3/6] gprs: Implement BSSGP MCC/MNC patching

On Thu, Jul 03, 2014 at 01:28:14PM +0200, Jacob Erlbeck wrote:

Good Evening Jacob,

• int old_local_mcc = state->local_mcc;
• int old_local_mnc = state->local_mnc;

make the above two const please.

• if (old_local_mcc != state->local_mcc ||

•    old_local_mnc != state->local_mnc)
  

• LOGP(DGPRS, LOGL_NOTICE,
  

•      "Patching RAID %sactivated, msg: %s, "
  

•      "local: %d-%d, core: %d-%d, to %s\n",
  

•      state->local_mcc || state->local_mnc ?
  

•      "" : "de",
  

•      log_text,
  

•      state->local_mcc, state->local_mnc,
  

•      gbcfg.core_mcc, gbcfg.core_mnc,
  

•      to_bss ? "BSS" : "SGSN");
  

• if (state->local_mcc || state->local_mnc) {

What does this extra check/message bring to the table? Why is it a notice?

• /* fix BSSGP */
• bssgp_tlv_parse(&tp, data, data_len);

What exactly is fixed here?

-struct gbproxy_config gbcfg; +struct gbproxy_config gbcfg = {0};

We were lucky before or did the gbcfg end in the BSS before the patch as well?

+#define GBPROXY_CORE_MNC_STR "Use this network code for the backbone\n"

No idea if "core-network" is any better.