Re: [PATCH libosmo-netif 08/18] osmux: introduce osmux_xfrm_input_close_circuit()

On Sat, Aug 08, 2015 at 09:04:12PM +0200, Holger Freyther wrote:

...

On 21 Jul 2015, at 16:23, pablo@gnumonks.org wrote:

• llist_del(&circuit->head);
• talloc_free(circuit);

What happens if there is a single circuit and the batch timer was running? I assume it will timeout not be rescheduled?

Good point.

Looking at osmux_xfrm_input_deliver() and assuming the ndummy counter became zero, it will not be rescheduled.

Regarding the normal voice path, I think it should be possible to pass an empty msgb to the deliver() callback if the timer is called after the circuit is gone, let me have a careful look at this.