Change in libosmocore[master]: Add function to make Uplink Measurement

Harald Welte has posted comments on this change. Change subject: Add function to make Uplink Measurement ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/44/1/include/osmocom/gsm/meas_rep.h File include/osmocom/gsm/meas_rep.h: Line 29: size_t gsm0858_rsl_ul_meas(struct gsm_meas_rep_unidir *mru, bool dtxd_used, In terms of naming, I would again like to see something more explicit. The name tells us the function is related to RSL uplink measurement, but what does it do? encode? decode? ... So gsm0858_rsl_ul_meas_enc or .._enc_ul_meas would be more applicable. -- To view, visit https://gerrit.osmocom.org/44 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib37107bcc9909e5105ea711de42d3fb1db7e8d9e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev(a)sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes