From Harald Welte laforge@gnumonks.org:
Harald Welte has posted comments on this change.
Change subject: Add function to make Uplink Measurement ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/44/1/include/osmocom/gsm/meas_rep.h File include/osmocom/gsm/meas_rep.h:
Line 29: size_t gsm0858_rsl_ul_meas(struct gsm_meas_rep_unidir *mru, bool dtxd_used, In terms of naming, I would again like to see something more explicit. The name tells us the function is related to RSL uplink measurement, but what does it do? encode? decode? ...
So gsm0858_rsl_ul_meas_enc or .._enc_ul_meas would be more applicable.