On Sun, Feb 09, 2014 at 01:35:46PM +0400, Alexander Chemeris wrote:
Alexander,
May be it's just me, but I find it impolite to ask someone to test a patch, just because you don't bother to test it yourself. Moreover when there it no a unit-test for the change - at least to make sure that the next_rp_ref doesn't overflow.
next_rp_ref and the message reference are of the same range. So it is intended to overlflow and I skipped the % UINT8_MAX.
We would be happy to test the patch in production environment, once it's at least initially tested and merged to mainline. So far we're busy with our own set of issues to be fixed, which are more severe than this one. Patches to be contributed soon.
In German we say "lieber den spatz in der hand, als die taube auf dem dach". We prepfer a little spaze over promises. I have seen your marketing about the contributions of Fairwaves, I have seen the promises of fixes coming. I just thought I could motivate you guys to actually fix something easy. I was wrong and there is no point in replying to this email. ;)
holger