Re: [PATCH 2/3] add bind address parameter to ctrl_interface_setup()

Hi Neels,

On Wed, Feb 24, 2016 at 03:39:37AM +0100, Neels Hofmeyr wrote:

-struct ctrl_handle *ctrl_interface_setup(void *data, uint16_t port,

• 			 ctrl_cmd_lookup lookup);
  

+struct ctrl_handle *ctrl_interface_setup(void *data, const char *bind_addr,

• 			 uint16_t port, ctrl_cmd_lookup lookup);
  

we generally don't beak interfaces of our libraries like this. Pleaes add a second/new function like (ctrl_interface_setup2 or ctrl_interface_setup_nonlocal, ctrl_interface_setup_bind, ...) with the new argument. This way old and new code works.

See telnet_init_dynif() vs. telnet_init() in libosmovty.