----- On Feb 6, 2017, at 2:55 PM, Harald Welte laforge@netfilter.org wrote:
Hi Andreas,
On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote:
Both function are always used together with the final goal to get the gtp_dev. This simplifies the code by merging them together.
Ok, some code restructuring / unification, seems useful.
However:
netdev_dbg(dev, "GTPv0-U: update tunnel id = %llx (pdp %p)\n",pctx->u.v0.tid, pctx);
pr_debug("GTPv0-U: update tunnel id = %llx (pdp %p)\n",pctx->u.v0.tid, pctx);(and other related changes) appear to be purely cosmetic and should thus be unrelated to the function merging described in the change log message.
The dev argument has been removed from the surrounding function. However, for those debug message having the network device information is use full. I've modified the code in v3 a bit to keep the debug message.
Andreas
--
- Harald Welte laforge@netfilter.org http://netfilter.org/
============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie