On Sun, Feb 9, 2014 at 1:48 PM, Holger Hans Peter Freyther holger@freyther.de wrote:
On Sun, Feb 09, 2014 at 01:28:05PM +0400, Alexander Chemeris wrote:
Please try to contribute and finish this patch or at least just make your modification available to the community.
I realized, that this is actually the final working version of the patch. I took you so long to get back to it, so I was thinking it's the original patch which was broken. Feel free to merge this into master.
It lacks a test case and the doubt if it works or not doesn't help either.
I doubt a unit-test is needed in this case, given the purpose of this code and that this code is more or less self-contained. If you want, you could try it yourself, but I have tested it on pretty large DB full of SMS messages.
But sure it is easy to demand things from others. ;)
I propose this to be the Rule #1 for this mailing list :) "Don't demand others to do work for you."