From Harald Welte <laforge(a)gnumonks.org>rg>:
Harald Welte has posted comments on this change.
Change subject: gsm48: move to hex TMSI representation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/57/1/src/gsm/gsm48.c
File src/gsm/gsm48.c:
PS1, Line 465: string
Because I saw that the 0x%08x format also used in
other Osmocom projects, f
I think the general representation in the industry would
be all-uppercase and without 0x, so "%08X". However, as we used to have integer
representation in OpenBSC so far, it might be a good idea to give the '0x' as a
hint to the user, so he knows this version of the log statement/vty output is in hex, as
opposed to earlier versions.
--
To view, visit
https://gerrit.osmocom.org/57
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator(a)gmail.com>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator(a)gmail.com>
Gerrit-HasComments: Yes