From Harald Welte laforge@gnumonks.org:
Harald Welte has posted comments on this change.
Change subject: gsm48: move to hex TMSI representation ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/57/1/src/gsm/gsm48.c File src/gsm/gsm48.c:
PS1, Line 465: string
Because I saw that the 0x%08x format also used in other Osmocom projects, f
I think the general representation in the industry would be all-uppercase and without 0x, so "%08X". However, as we used to have integer representation in OpenBSC so far, it might be a good idea to give the '0x' as a hint to the user, so he knows this version of the log statement/vty output is in hex, as opposed to earlier versions.