Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/160/1/include/osmocom/codec/codec.h File include/osmocom/codec/codec.h:
Line 46: bool osmo_check_sid_hr(uint8_t *rtp_payload, size_t payload_len); the other functions are calld osmo_<codec>_<something>, while your new functions are osmo_<something>_<codec>, which is a minor inconsistency. But let's ignore that.
https://gerrit.osmocom.org/#/c/160/1/src/codec/gsm610.c File src/codec/gsm610.c:
Line 320: return false; mh, this code doesn't really look very nice, like lots of copy+paste. why not have a 'const unsigned int sid_bits[] array with the bit numbers, and a nice for-loop to iterate over sid_bits?