From Holger Freyther holger@freyther.de:
Holger Freyther has posted comments on this change.
Change subject: gsm48: move to hex TMSI representation ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/57/1/src/gsm/gsm48.c File src/gsm/gsm48.c:
PS1, Line 461: It is not a "reverse" anymore. Should the comment be updated? Specially with gsm48_generate_mid_from_tmsi just taking the uint32?
PS1, Line 465: string Why do you prefix it with 0x here? In the commit message I would like to have a small statement about the minimum size of the "string" not having.
Who consumes the result and does the represntation matter?