Re: [PATCH] [RFC] src: add prefix osmocom_ to all functions in libosmocore

Hi Pablo, On Sun, Mar 27, 2011 at 09:37:54PM +0200, pablo(a)gnumonks.org wrote: I think 'osmocom_' is too long. 'osmo_' should be better. And yes, generally it would make sense to prefix most functions. Exceptions: * libosmovty should have a common vty_ prefix, but not osmo. * for libosmovty we should probably simply limit the number of exported symbols. There is e.g. all the buffer_*() and vector_*() use internally, but there is no need to globally export all those symbols. * no osmo_ prefix for msgb_* and tlv_*, as they are used everywhere * no prefix for talloc * bitvec_* -> osmo_bv_* * bsc_*_timer -> osmo_timer_* * *_signal_* -> osmo_signal_* I think it's great. Once the namespace is cleaned up, I think we can head for a 1.0 release of the libraries. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)