Re: [PATCH] sms: Rename gsm340_gen_oa() to gsm340_gen_address_field().

On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote:

Good idea. An updated patch is attached.

+/* DEPRECATED: use gsm340_gen_address_field() instead */ +int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type,

• uint8_t plan, const char *number) OSMO_DEPRECATED("Use gsm340_gen_address_field() instead");

this comment doesn't really add any value. You are using OSMO_DEPRECTAED but you do not directly/indirectly the header file defining it. In fact gsm0411_smc.c fails to compile due this.