Re: [PATCH 1/6] gprs-ns/test: Use gprs_nsvc_reset instead of gprs_ns_tx_reset

On Wed, Oct 08, 2014 at 12:05:13PM +0200, Jacob Erlbeck wrote:

Currently gprs_ns_tx_reset is used to let the NS stack generate NS_RESET message. This is not adjusting the nsvc state properly.

This patch uses gprs_nsvc_reset instead which starts the full reset procedure.

Shall we patch gprs_nsvc_reset to return the error from the gprs_ns_tx_reset call?

• rc = gprs_ns_tx_reset(nsvc, NS_CAUSE_OM_INTERVENTION);
• if (rc < 0)

• printf("Failed to send RESET to %s\n\n", gprs_ns_ll_str(nsvc));
  

• else {

• send_ns_reset_ack(nsi, nse[1], 0x2001, 0x2000);
  

• gprs_dump_nsi(nsi);
  

• }

• gprs_nsvc_reset(nsvc, NS_CAUSE_OM_INTERVENTION);

e.g. we entered the "failed" path here and don't capture the log output. of libosmogb.