6 Oct
2016
6 Oct
'16
4:09 p.m.
Hi.
I have not ignored anything, I've pointed to commit which I suspect
could have broken voice (as you rightfully pointed out it's in
libosmo-abis). Could you clarify if reverting this commit in
libosmo-abis fixes the voice for sysmobts master? Or in addition to
reverting c77c2a6aa13accbc558888ab788d1148eb9aeb1a in libosmo-abis I've
got to checkout some later commit in sysmobts?
If reverting commit in libosmo-abis indeed fixes voice for sysmobts sdk
1.5.4 than please send patch for review (add me as reviewer).
Right now I'm working on DTX rewrite using FSM which might fix sysmobts
if it's indeed broken (after fixing libosmo-abis).
On 10/06/2016 04:01 PM, Neels Hofmeyr wrote:
[SDK 1.5.4 has no voice]
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
This might be related to commit
c77c2a6aa13accbc558888ab788d1148eb9aeb1a
in osmobts - see https://projects.osmocom.org/issues/1661
osmo-bts has no commit
c77c2a6aa13accbc558888ab788d1148eb9aeb1a.
...you mean libosmo-abis.
If you roll-back this commit, does voice
re-appear?
Wow, it actually does! I was pretty sure this would not fix anything. I
have
discussed in detail in OS#1661, and see https://gerrit.osmocom.org/1011 .
A pressing issue which you seemingly ignored is that your osmo-bts commit
654175f33bd412671e3ef8cdd65c0689d10f278c breaks voice on SysmoBTS. Could you
grab a sysmoBTS and verify+fix it soon? Otherwise revert.
~Neels