28 Oct
2015
28 Oct
'15
2:59 p.m.
On Wed, Oct 28, 2015 at 04:40:48AM +0100, Pablo Neira Ayuso wrote:
Try to send a small batch to start with, to avoid a
small patchbomb
thing ;-)
*cough* like my patch bombs...
But, in fact, I would personally prefer to read a large number of small
neat patches than a small number of large convoluted patches.
So me, I'm basically all for patch bombs (presuming sufficiently detailed
commit log messages). They are rather easy to skip in the mail inbox and
allow for easier review.
It can pay off to invest "too much" time in restructuring/splitting
patches, allowing N people to save time reading them. My occasional tiny
cosmetic patches are split off for this reason alone.
I wonder if you can find a good way to split this in
logic changes to
make the review easier.
There, you said it ;)
But, please do let me know if I should refrain from sending patch bombs...
(My current work being sponsored does produce a lot of patches, and once
Holger is done reviewing the last one, there's a lot more to come.)
~Neels