Re: [PATCH 3/6] sms: Rename gsm340_gen_tpdu() to gsm340_gen_sms_deliver_tpdu() to show that it generates SMS-DELIVER TPDU and is not a generic function.

On Sun, Mar 09, 2014 at 11:58:04AM +0100, Alexander Chemeris wrote: man git-commit(1): "Though not required, it’s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first blank line in a commit message is treated as the commit title, and that title is used throughout Git. For example, git-format-patch(1) turns a commit into email, and it uses the title on the Subject line and the rest of the commit in the body." Please try to follow that. Why "an"? Isn't "a" correct here? Document that < 0 indicates error? And the comment style is only for net/* ;) I have applied it anyway as the naming of the method appears to be a lot better. holger