Re: [PATCH] rsl: Implement handling of rsl Delete Ind message

18 февр. 2014 г. 11:02 пользователь "Holger Hans Peter Freyther" < holger@freyther.de> написал:

On Mon, Feb 17, 2014 at 04:50:42PM +0400, Ivan Kluchnikov wrote:

Good Morning,

...

•         llist_for_each_entry(cur_trx, &trx->bts->trx_list, list) {
  

•                 if (cur_trx->arfcn == arfcn) {
  

I wondered if we want to compare the access reference as well? We do not enforce that the ARFCNs of a TRX are distinct.

Actually I think we should rather start enforcing that. Or do you know situations when both TRX's could run on the same ARFCN?

And besides that I would like you to move the look-up code to a separate function. That way we can at least write a unit test in the future.

+1

Please excuse typos. Written with a touchscreen keyboard.

-- Regards, Alexander Chemeris CEO/Founder Fairwaves LLC http://fairwaves.ru