28 Oct
2015
28 Oct
'15
4:40 a.m.
On Tue, Oct 27, 2015 at 10:13:58AM +0100, Andreas Schultz wrote:
This is a fairly large changeset (20 patches), I'd suggest you start
with bugfixes in first place. The patches are lacking also
descriptions, they are important.
Try to send a small batch to start with, to avoid a small patchbomb
thing ;-)
The update to port this on top of iptunnel is fairly large, I would
expect that. I wonder if you can find a good way to split this in
logic changes to make the review easier.
Thanks.
On 10/27/2015 08:36 AM, Harald Welte wrote:
[...]
I think it
would be best (and customary practise) to send your changes
to this list (using git format-patch / send-email) for review.
Will do, but I think I will have to rework the changesets a bit. There
are a few intermediate commits that can probably be squashed and others
that might have to be split.