26 Jan
2014
26 Jan
'14
10:32 p.m.
On Sun, Jan 26, 2014 at 09:57:03AM +0100, Andreas Eversberg wrote:
Holger Hans Peter Freyther wrote:
>Please attempt to write comments in a way that one can understand them
>in a year later. What will be tried later? But actually try for me means
>that the code would actually execute a deferred action while here it will
>simply react to another function call.
+ /* In case, we don't have a RTP socket to the
BTS yet, we try
+ * later when the socket has been created and connected. */
if (!lchan->abis_ip.rtp_socket) {
- trans->tch_recv = enable;
sorry to nitpick but these things matter when people read someone else's
code in order to understand how things work. Right now I am not able to
understand "what" will be tried later?
Maybe something like this:
/* In case we don't have a RTP socket to the BTS yet, the code
* can not connect the sockets and will return. This method will
* be called for the next NET->BTS frame and once audio is connected
* from the BTS. */
or something along the lines.
+ /* In case we don't have a TCH with correct
mode, we try later
+ * after assignment or handover is complete. This is performed
+ * by switch_trau_mux() then. */
Similar. s/try/will be done/