Re: [PATCH] Fix IE lengths in the sgsn code

Hi,

On Wed, Jul 3, 2013 at 11:08 AM, Holger Hans Peter Freyther holger@freyther.de wrote:

On Wed, Jul 03, 2013 at 10:19:45AM +0400, Alexander Chemeris wrote:

...

Hi all,

Attached patch fixes lengths of MS Network Capability and MS Radio Access Capability elements.

Original code was inconsistent about lengths and could lead to out of bounds write. Lengths were also inconsistent with the TS 24.008.

maybe add a "Fixes Coverity CID 1040714" to the commit message, or at least "found by coverity"?

I think it's a good idea, but it's up to you to establish the workflow. Feel free to add one of these lines to the commit message.

-- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru