Hi Pablo,
On Fri, May 06, 2011 at 12:28:04PM +0200, pablo@gnumonks.org wrote:
This is the first patchset that fixes the namespace pollution in libosmocore.
thanks.
You can find in the patch description the sed regular expression to automate the replacement of the function/structure names, e.g:
great idea.
You can find it in the pablo/namespace branch. Please, merge it!
Ok, I have checked the 'nm' output of current libosmocore.a of that branch, and the only functions without an osmo_ prefix are:
msgb_* (which is ok) bitvec_* (which is ok, too) log_* (i guess ok, too) gsmtap_* (which is ok) talloc_* (which is ok) rate_ctr_* (which is ok) chantype_rsl2gsmtap (ok) get_string_value/get_value_string (ok)
However, there are seome others. Pablo, can you please also prefix those: bcd2char, char2bcd crc16 generate_backtrace plugin_load_all
Once this has been resolved, I will merge your branch.
We should also make a first official libosmocore release soon, and from now on make sure we keep binary (ABI) compatibility within the autotools library versioning rules. As a second step, we can try to get the library included in Debian and other distros.
Finally, we have one remaining issue: msg_entry_parse
I think msg / msgb are a bit too close and they don't do anything related. Maybe we can come up with a different name, possibly including the osmo_ prefix? Holger?
Regards, Harald