31 May
2016
31 May
'16
12:21 p.m.
Patch Set 7:
Of course textual output would catch a change in return value of memcmp. The issue we had
is that as part of a bigger change so much output was changed that something that should
have been catched by an OSMO_ASSERT was not.
So my point is:
* Use OSMO_ASSERT for a strong post-condition/result check
* Have the output as a safety net for side-effects and accidental changes
--
To view, visit https://gerrit.osmocom.org/118
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia217679a07d3fbc970f435e20f6eac33d34bd597
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev(a)sysmocom.de>
Gerrit-HasComments: No