Re: new timer code: semantics of osmo_timer_schedule for already scheduled timer

On Fri, Nov 11, 2011 at 06:50:31PM +0100, Harald Welte wrote:

Hi all,

On Fri, Nov 11, 2011 at 03:56:21PM +0100, Sylvain Munaut wrote:

...

While updating libosmocore in osmocom-bb, a problem arised: 100%CPU usage and hanging. Turns out 'mobile' sometimes call osmo_timer_schedule for an already scheduled timer.

Obviously this used to work and now it doesn't. The question is : Was there a defined semantics for this case previously ? Or is it supposed to be unsupported ? What would you expect it to do ?

I think a second/follow-up timer_schedule should re-schedule the existing timer safely.

The patch attached should recover the former behaviour, sorry for missing this case.