Patch Set 2:
I know that in_release==1 so msc_release_connection() is a nop.
It is really weird to set a flag that disables a function completely
and then call that function anyway.
I find that confusing, but if you don't agree we can drop this change.
--
To view, visit
https://gerrit.osmocom.org/93
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf9eb4889d32ad5e42ac7d096bf62fa3a493e20
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-HasComments: No