22 Nov
2013
22 Nov
'13
5:34 p.m.
22.11.2013 17:07, Harald Welte пишет:
Hi Max,
thanks for your patch.
I think it would make more sense to
1) add XOR to libosmocore
Was it actually used for anything besides internal testing inside OpenBSC?
I do not recall seeing xor "hash function" in gsm spec, so I'm not sure it
will be
generally useful except for giving nightmares to security researchers :)
2) have a table or function to map from
AUTH_ALGO_COMP128v1 to
OSMO_AUTH_ALG_COMP128v1 (as well as mappings for any other ciphers
Can we use OSMO_AUTH_ALG_COMP128v1 directly? As far as I can see it's only used to
map some text into algorithm in vty code and than use selected algorithm in auth
code. What is include/openbsc/gsm_data.h for?
at that time, _use_xor() / _use_comp128_v1() become
superfluous, and
auth_get_tuple_for_subscr() can call osmo_auth_gen_vec() directly.
I was thinking to use osmo_auth_gen_vec() and replace gsm_auth_tuple with
osmo_auth_vec but I'm not sure what parts of libmsc considered as "stable"
api so I
opted for minimum-intrusion patches just to get rid of direct access to libosmocore's
comp128v* functions. Of course the more generic code from libosmocore is used - the
better.
--
best regards,
Max, http://fairwaves.ru