2 Jul
2022
2 Jul
'22
5:37 p.m.
Hi Lennart and Mychaela,
I think it is indeed best to apply a fix to libosmocore, where the parser is. The functional split is a bit ... arbitrary ... there.
The best way to handle this would be to also add a test caes, probably easiest in terms of a unit test (in libosmocore/tests), showing that both the longer/later version and the shorter/older version parse with the correct expectations. That's not required, but it's the only way to really ensure it won't break in the future.
Is either of you going to submit the patch (with or without unit test) via gerrit? https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit
Thanks again, Harald
--
- Harald Welte laforge@osmocom.org http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)