Re: [PATCH 3/4] input: Make keep alive configurable (generic)

On Thu, Jan 09, 2014 at 02:30:57PM +0100, Jacob Erlbeck wrote:

This patch adds a generic keep alive configuration layer that mainly consists of additional fields in e1_input structs and VTY commands and extensions.

enum e1inp_sign_type { E1INP_SIGN_NONE, @@ -134,6 +135,7 @@ struct e1inp_driver { void (*close)(struct e1inp_sign_link *link); void (*vty_show)(struct vty *vty, struct e1inp_line *line); int default_delay;

• int has_keepalive;

};

This changes ABI and we should establish a generic way to error when making a new release and forgetting to update the LIBVERSION. I can think of doing:

* Modify configure.ac to check the version number and error if a LIBVERSION change is pending. * Use #error in the header file when the XXX version is changed?