Re: 7 patches

Holger Hans Peter Freyther wrote:

it is still way too big...

• e.g... it adds handling for TCH.. when you are just starting with the BCCH...

• you really don't need to put everything into a single method. Try to put unrelated things into separate methods. Nobody can understand a method that has 1000 lines of codes and tons of if/else in it.

i did some seperation:

- first i committed the l1sap interface header, because it includes all macros that are relevant for for later primitives. - then the actual BCCH implementation, which includes the base parts of the l1sap interface. - last the gsmtap support for the l1sap message primitives. the function is now splitted.

i think that later this gsmtap support should be placed at the end of all primitives patches.

what do you think?