Re: [RFC] GTP-U v0/v1 kernel module

Hi Andreas, good to seee you on the mailing list, and thanks for sharing your work. On Mon, Oct 26, 2015 at 06:14:19PM +0100, Andreas Schultz wrote: This is for historical reasons... I've now moved the kernel part to http://git.osmocom.org/osmo-gtp-kernel/ and the 'osmocom developers with commit access' can now push to it via git://gitosis@git.osmocom.org:osmo-gtp-kernel.git I would have expected a higher percentage, but then indeed it is true, the project got halted / postponed at the time due to changing customer requirements, as far as I remember I think it would be best (and customary practise) to send your changes to this list (using git format-patch / send-email) for review. After a brief initial review it looks fine to me, but Pablo is clearly the better judge of that. One thing I seem to notice immediaately at a brief look is that it appears often 8 spaces are used instead of tab for indentation. I know it's picky, but that has to be adressed before any mainline merge attempt :/ I think you mentioned last week that you still had some issues with module unloading ? It would be good to share any remaining problems, maybe somebody has some idea/input on what is causing the problem. Please also feel free to add yourself to the list of Copyright holders in the file headers, so we have proper documentation of that before submission. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)