On Wed, Mar 20, 2019 at 06:12:30PM +0100, Pau Espin Pedrol wrote:
Another topic that I forgot to list is signal handling. I would think it makes sense to move the SIGUSR1/SIGUSR2 handling into libosmocore now, particularly as we have the root talloc context[s] in libosmocore with my related patches. It just sucks to have to have a SIGUSR1->talloc_dump code snippet in each and every of our programs.
Please don't. Let's allow apps decide how they handle user-defined signals and not try doing everything in a generic library.
I think it's better to avoid the code dup in each application, have well-defined standard handlers once.
Thinking in terms of one global libosmocore subsystem config struct, this could be switch-off-able.
If it were implicit any application can easily put other signal handlers in place after the fact.
~N