I'd like to re-raise this patch I merged for discussion, it's about whether or not OsmoMGW endpoint identifiers are in hex. My patch might have gone in the wrong direction after all.
https://gerrit.osmocom.org/4780
~N
On Sat, Dec 02, 2017 at 06:53:39PM +0000, Neels Hofmeyr wrote:
Patch Set 2:
elsewhere it seems we are confirming the hex nature of endpoint IDs (or was that a connection identifier?) ... Possibly this needs to be fixed the other way, by libosmo-mgcp-client translating the number-of-endpoints to a hex representation?
-- To view, visit https://gerrit.osmocom.org/4780 To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic18608ff23303c1564548a86d5f6bfa539fe555e Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr nhofmeyr@sysmocom.de Gerrit-Reviewer: Harald Welte laforge@gnumonks.org Gerrit-Reviewer: Holger Freyther holger@freyther.de Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr nhofmeyr@sysmocom.de Gerrit-HasComments: No