Re: [PATCH 1/8] mgcp: Rename for_each_line to for_each_non_empty_line

On Fri, Nov 29, 2013 at 01:43:43PM +0100, Jacob Erlbeck wrote:

The implementation of for_each_line is based on strtok() and skips any sequence of CR and LF. Thus empty lines are never detected. There exists code which tests for an empty line to detect the beginning of the SDP part which is dead code currently (the parser works nevertheless due to other reasons). So the semantics of this macro have been misunderstood at least once.

This patch renames the macro to reflect the semantics more precisely.

Do you want to remove the "case '\0':" lines (just to add them in later commits again)?