Re: [PATCH 1/2] Added new auth policy blacklist.

On Fri, Oct 18, 2013 at 12:37:42PM +0400, Ivan Kluchnikov wrote:

Dear Ivan,

case GSM_AUTH_POLICY_CLOSED: return subscriber->authorized == GSM_SUBSCRIBER_AUTH_AUTHORIZED; ...

return (subscriber->flags & GSM_SUBSCRIBER_FIRST_CONTACT);

case GSM_AUTH_POLICY_ACCEPT_ALL: return 1;

• case GSM_AUTH_POLICY_BLACKLIST:

• return subscriber->authorized;
  

return subscriber->authorized != GSM_SUBSCRIBER_AUTH_BLACKLIST; then you can omit this code.

• if (subscr) { subscr->net = net;

• if (subscr->net->auth_policy == GSM_AUTH_POLICY_BLACKLIST) {
  

• 	subscr->authorized = 1;
  

The benefit is that moving from closed to black-list works without changing the database content. If you move from black-list to closed.. all your blacklisted subscribers are suddenly allowed.

holger