8 Sep
2014
8 Sep
'14
1:11 p.m.
Hi Daniel,
in order to reduce the line length a bit, I would sugegst to change
+ LOGP(DMM, level, "MM(imsi=%s p-tmsi=0x%08x
tlli=0x%08x) " fmt, (mm)->imsi, (mm)->p_tmsi, (mm)->tlli, ## args)
to
+ LOGP(DMM, level, "MM(%s/%08x/%08x) " fmt,
(mm)->imsi, (mm)->p_tmsi, (mm)->tlli, ## args)
or even leave the TLLI away, as I presume if you use the mm-context TLLI
(and not the TLLI that was read from the currently processed message),
then it will be a quite predictable derivate of the P-TMSI anyway.
+ LOGP(DGPRS, level, "PDP(imsi=%s ti=%u) "
fmt, (pdp)->mm->imsi, (pdp)->ti, ## args)
here also one could change it to
+ LOGP(DGPRS, level, "PDP(%s/%u) " fmt,
(pdp)->mm->imsi, (pdp)->ti, ## args)
to save some characers in line length, which
a) make it more difficult to read the log messages on screens of limited
widdth
b) reduce the log file size as it accumulates over time.
Apart from that the patches should be merged, from my point of view.
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)