On Sun, 2014-01-26 at 08:44, Holger Hans Peter Freyther wrote:
Maybe it is time for gerrit or at least a set-up for patchwork. I had a look at your branch and stopped at the first commit message. :)
In an attempt to prevent issues with my other patches I reviewed them again and found some more issues. I pushed an updated and rebased version to daniel/smpp-fixes and will send the patchset here as well.
"Before this patch we just loop over the fd with read returning -1.." ==> looped (past tense)?
Right, fixed.
I don't think it is true. osmo_fd_register will enable O_NONBLOCK on the socket and I think we use that to register the fd.
You're right, the reason is wrong. Checking for these codes is still not needed, though (since we get called only if there's something to read.
the actual fixes look nice though. :)
At least something :-)
Regards, Daniel