Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/101/1/openbsc/src/libbsc/system_information.c
File openbsc/src/libbsc/system_information.c:
Line 935: gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
Okay. so we are not on BCCH so it needs to be false here. But what do you think of using
an enum value in the long run here?
--
To view, visit
https://gerrit.osmocom.org/101
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d41df0068783c8fb33ddeeab1d1dcf63c2c259f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes