6 Apr
2016
6 Apr
'16
12:24 p.m.
On Fri, Apr 01, 2016 at 08:33:33PM +0200, Holger Freyther wrote:
From: Holger Hans Peter Freyther
<holger(a)moiji-mobile.com>
Add testcase to issue the subscriber create twice.
Could be nice to add this clarification in the test code as comment:
db_create_subscriber in db.c will first try to find
the subscriber and if it
exists, it will update the "updated" column in the database.
[...]
+
+ # Lets create one
+ res = self.vty.command('subscriber create imsi '+imsi)
+ self.assert_(res.find(" IMSI: "+imsi) > 0)
... right here.
+ res2 = self.vty.command('subscriber
create imsi '+imsi)
+ self.assert_(res2.find(" IMSI: "+imsi) > 0)
+ self.assertEqual(res, res2)
The test isn't testing the update of the 'updated' column, right? Why though
would the db want to update the 'updated' column for such a noop anyway?
~Neels