18 Jan
2019
18 Jan
'19
9:58 a.m.
Hi Neels,
On Thu, Jan 17, 2019 at 05:50:05PM +0100, Neels Hofmeyr wrote:
Should we now put copyright comments in header files
as well?
re https://gerrit.osmocom.org/c/osmo-msc/+/11642/3/include/osmocom/msc/sgs_ifa…
yes, it is general practise.
When I see structs containing talloc'd char*,
should I generally give code
review to use fixed char arrays instead? I think it ends up being simpler
semantically as well as better in terms of mem allocation. Right? e.g.
https://gerrit.osmocom.org/c/osmo-msc/+/11642/30/include/osmocom/msc/sgs_se…
and #21
My general rule of thumb is:
* if the string length is [relatively] bounded and the most common case is that
the enclosing structure will have such a string present -> static array
* if the string length is rather unbounded and/or there are many use cases where
the string is not used at all -> pointer + talloc
There may be other factors to take into consideration. For strings that can
change at the lietime of the structure, such as 'name' or 'description'
bits
that are accessible from the VTY, we've traditionally used
osmo_talloc_replace_string()
as a hepler and then there's some tendency to do that. But then, if it were a
static array, we'd simply use OSMO_STRLCPY_ARRAY() which is equally easy to use.
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)