Patch Set 2:
I think what we can argue about is. Either way you need to wonder how the calls deal in case of the release.
* Either you know that release_loc_updating_req can be asked not to msc_release_connection
* Or you know that because you set in_relase = 1, msc_release_connection will be called but that it is a no-op.
So do you really think that doing it this way is more readable/more obvious?
--
To view, visit
https://gerrit.osmocom.org/93
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf9eb4889d32ad5e42ac7d096bf62fa3a493e20
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Holger Freyther
holger@freyther.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No