Re: [PATCH 1/3] smpp_smsc: Print errno and close socket if read returns -1

On Mon, 2014-01-20 at 20:28, Holger Hans Peter Freyther wrote:

On Mon, Jan 20, 2014 at 07:47:23PM +0100, Daniel Willmann wrote:

...

I found another issue as well which I rolled into my last patch. msgb_alloc takes a uint16_t as size so the check was still wrong.

good catch! Shall we export something from MSGB to indicate the maximum msgb size?

I'm not opposed, but I don't see how it would help anything. I doubt that whoever forgot to check the function signature will remember to compare the length against a define.

Regards, Daniel