OpenBSC

openbsc@lists.osmocom.org

10 participants
4188 discussions

That patch again...
by Mike Haben 02 Oct '09

02 Oct '09

Sorry about that Holger, another lesson learned - I'd manually edited the patch to remove an extra line. Now recreated from scratch. Very much like Harald's idea of reading the model / frequency-band from the unit - may end up with GSM_BTS_TYPE_NANOBTS_OLD and GSM_BTS_TYPE_NANOBTS_NEW or similar? Best regards, Mike H.

1 0

[PATCH] Add support for 1900 nanoBTS by using unified bts_type GSM_BTS_TYPE_NANOBTS for 900, 1800 and 1900 versions Signed-off-by: Mike Haben <michael.haben@...>
by Mike 02 Oct '09

02 Oct '09

--- openbsc/include/openbsc/gsm_data.h | 6 ++---- openbsc/src/abis_nm.c | 3 +-- openbsc/src/bsc_init.c | 24 +++++++++++++----------- openbsc/src/gsm_04_08.c | 3 +-- openbsc/src/gsm_data.c | 3 +-- openbsc/src/ipaccess-config.c | 2 +- 6 files changed, 19 insertions(+), 22 deletions(-) diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h index 495f741..a493a69 100644 --- a/openbsc/include/openbsc/gsm_data.h +++ b/openbsc/include/openbsc/gsm_data.h @@ -242,8 +242,7 @@ struct gsm_bts_trx { enum gsm_bts_type { GSM_BTS_TYPE_UNKNOWN, GSM_BTS_TYPE_BS11, - GSM_BTS_TYPE_NANOBTS_900, - GSM_BTS_TYPE_NANOBTS_1800, + GSM_BTS_TYPE_NANOBTS, }; /** @@ -445,8 +444,7 @@ extern void *tall_bsc_ctx; static inline int is_ipaccess_bts(struct gsm_bts *bts) { switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: return 1; default: break; diff --git a/openbsc/src/abis_nm.c b/openbsc/src/abis_nm.c index 35ed8db..9a2fad7 100755 --- a/openbsc/src/abis_nm.c +++ b/openbsc/src/abis_nm.c @@ -1025,8 +1025,7 @@ static int abis_nm_rcvmsg_manuf(struct msgb *mb) int bts_type = mb->trx->bts->type; switch (bts_type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: rc = abis_nm_rx_ipacc(mb); break; default: diff --git a/openbsc/src/bsc_init.c b/openbsc/src/bsc_init.c index c626415..78e9861 100644 --- a/openbsc/src/bsc_init.c +++ b/openbsc/src/bsc_init.c @@ -526,8 +526,7 @@ static void nm_reconfig_trx(struct gsm_bts_trx *trx) sizeof(trx1_attr_radio)); } break; - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: trx->nominal_power = 20; default: break; @@ -594,8 +593,7 @@ static void bootstrap_om(struct gsm_bts *bts) case GSM_BTS_TYPE_BS11: bootstrap_om_bs11(bts); break; - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: bootstrap_om_nanobts(bts); break; default: @@ -985,23 +983,27 @@ void input_event(int event, enum e1inp_sign_type type, struct gsm_bts_trx *trx) static int bootstrap_bts(struct gsm_bts *bts) { - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_1800: + switch (bts->band) { + case GSM_BAND_1800: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { fprintf(stderr, "GSM1800 channel must be between 512-885.\n"); return -EINVAL; } break; - case GSM_BTS_TYPE_BS11: - case GSM_BTS_TYPE_NANOBTS_900: - /* Assume we have a P-GSM900 here */ + case GSM_BAND_1900: + if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { + fprintf(stderr, "GSM1900 channel must be between 512-810.\n"); + return -EINVAL; + } + break; + case GSM_BAND_900: if (bts->c0->arfcn < 1 || bts->c0->arfcn > 124) { fprintf(stderr, "GSM900 channel must be between 1-124.\n"); return -EINVAL; } break; - case GSM_BTS_TYPE_UNKNOWN: - fprintf(stderr, "Unknown BTS. Please specify\n"); + default: + fprintf(stderr, "Unsupported frequency band.\n"); return -EINVAL; } diff --git a/openbsc/src/gsm_04_08.c b/openbsc/src/gsm_04_08.c index bac920e..9ad9e15 100644 --- a/openbsc/src/gsm_04_08.c +++ b/openbsc/src/gsm_04_08.c @@ -1954,8 +1954,7 @@ static int tch_map(struct gsm_lchan *lchan, struct gsm_lchan *remote_lchan) } switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: if (!ipacc_rtp_direct) { /* connect the TCH's to our RTP proxy */ rc = ipacc_connect_proxy_bind(lchan); diff --git a/openbsc/src/gsm_data.c b/openbsc/src/gsm_data.c index a50ba8c..6767c3f 100644 --- a/openbsc/src/gsm_data.c +++ b/openbsc/src/gsm_data.c @@ -232,8 +232,7 @@ char *gsm_ts_name(struct gsm_bts_trx_ts *ts) static const char *bts_types[] = { [GSM_BTS_TYPE_UNKNOWN] = "unknown", [GSM_BTS_TYPE_BS11] = "bs11", - [GSM_BTS_TYPE_NANOBTS_900] = "nanobts900", - [GSM_BTS_TYPE_NANOBTS_1800] = "nanobts1800", + [GSM_BTS_TYPE_NANOBTS] = "nanobts", }; enum gsm_bts_type parse_btstype(const char *arg) diff --git a/openbsc/src/ipaccess-config.c b/openbsc/src/ipaccess-config.c index 7358d64..46043d5 100644 --- a/openbsc/src/ipaccess-config.c +++ b/openbsc/src/ipaccess-config.c @@ -348,7 +348,7 @@ int main(int argc, char **argv) if (!gsmnet) exit(1); - bts = gsm_bts_alloc(gsmnet, GSM_BTS_TYPE_NANOBTS_900, HARDCODED_TSC, + bts = gsm_bts_alloc(gsmnet, GSM_BTS_TYPE_NANOBTS, HARDCODED_TSC, HARDCODED_BSIC); register_signal_handler(SS_NM, nm_sig_cb, NULL); -- 1.6.0.4 --------------010903070906000806000204--

1 0

Oops...
by Mike Haben 02 Oct '09

02 Oct '09

Sorry about the message before last - how the hell did git do that? Mike H.

2 1

[PATCH] Add support for 1900 nanoBTS by using unified GSM_BTS_TYPE_NANOBTS to cover 900, 1800 and 1900 versions Signed-off-by: Mike Haben <michael.haben@...>
by Mike 01 Oct '09

01 Oct '09

--- openbsc/include/openbsc/gsm_data.h | 6 ++---- openbsc/src/abis_nm.c | 3 +-- openbsc/src/bsc_init.c | 23 +++++++++++++---------- openbsc/src/gsm_04_08.c | 3 +-- openbsc/src/gsm_data.c | 3 +-- openbsc/src/ipaccess-config.c | 2 +- 6 files changed, 19 insertions(+), 21 deletions(-) diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h index 495f741..a493a69 100644 --- a/openbsc/include/openbsc/gsm_data.h +++ b/openbsc/include/openbsc/gsm_data.h @@ -242,8 +242,7 @@ struct gsm_bts_trx { enum gsm_bts_type { GSM_BTS_TYPE_UNKNOWN, GSM_BTS_TYPE_BS11, - GSM_BTS_TYPE_NANOBTS_900, - GSM_BTS_TYPE_NANOBTS_1800, + GSM_BTS_TYPE_NANOBTS, }; /** @@ -445,8 +444,7 @@ extern void *tall_bsc_ctx; static inline int is_ipaccess_bts(struct gsm_bts *bts) { switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: return 1; default: break; diff --git a/openbsc/src/abis_nm.c b/openbsc/src/abis_nm.c index 35ed8db..9a2fad7 100755 --- a/openbsc/src/abis_nm.c +++ b/openbsc/src/abis_nm.c @@ -1025,8 +1025,7 @@ static int abis_nm_rcvmsg_manuf(struct msgb *mb) int bts_type = mb->trx->bts->type; switch (bts_type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: rc = abis_nm_rx_ipacc(mb); break; default: diff --git a/openbsc/src/bsc_init.c b/openbsc/src/bsc_init.c index c626415..3f5df23 100644 --- a/openbsc/src/bsc_init.c +++ b/openbsc/src/bsc_init.c @@ -526,8 +526,7 @@ static void nm_reconfig_trx(struct gsm_bts_trx *trx) sizeof(trx1_attr_radio)); } break; - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: trx->nominal_power = 20; default: break; @@ -594,8 +593,7 @@ static void bootstrap_om(struct gsm_bts *bts) case GSM_BTS_TYPE_BS11: bootstrap_om_bs11(bts); break; - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: bootstrap_om_nanobts(bts); break; default: @@ -985,23 +983,28 @@ void input_event(int event, enum e1inp_sign_type type, struct gsm_bts_trx *trx) static int bootstrap_bts(struct gsm_bts *bts) { - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_1800: + switch (bts->band) { + case GSM_BAND_1800: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { fprintf(stderr, "GSM1800 channel must be between 512-885.\n"); return -EINVAL; } break; - case GSM_BTS_TYPE_BS11: - case GSM_BTS_TYPE_NANOBTS_900: + case GSM_BAND_1900: + if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { + fprintf(stderr, "GSM1900 channel must be between 512-810.\n"); + return -EINVAL; + } + break; + case GSM_BAND_900: - /* Assume we have a P-GSM900 here */ if (bts->c0->arfcn < 1 || bts->c0->arfcn > 124) { fprintf(stderr, "GSM900 channel must be between 1-124.\n"); return -EINVAL; } break; - case GSM_BTS_TYPE_UNKNOWN: - fprintf(stderr, "Unknown BTS. Please specify\n"); + default: + fprintf(stderr, "Unsupported frequency band.\n"); return -EINVAL; } diff --git a/openbsc/src/gsm_04_08.c b/openbsc/src/gsm_04_08.c index bac920e..9ad9e15 100644 --- a/openbsc/src/gsm_04_08.c +++ b/openbsc/src/gsm_04_08.c @@ -1954,8 +1954,7 @@ static int tch_map(struct gsm_lchan *lchan, struct gsm_lchan *remote_lchan) } switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS_900: - case GSM_BTS_TYPE_NANOBTS_1800: + case GSM_BTS_TYPE_NANOBTS: if (!ipacc_rtp_direct) { /* connect the TCH's to our RTP proxy */ rc = ipacc_connect_proxy_bind(lchan); diff --git a/openbsc/src/gsm_data.c b/openbsc/src/gsm_data.c index a50ba8c..6767c3f 100644 --- a/openbsc/src/gsm_data.c +++ b/openbsc/src/gsm_data.c @@ -232,8 +232,7 @@ char *gsm_ts_name(struct gsm_bts_trx_ts *ts) static const char *bts_types[] = { [GSM_BTS_TYPE_UNKNOWN] = "unknown", [GSM_BTS_TYPE_BS11] = "bs11", - [GSM_BTS_TYPE_NANOBTS_900] = "nanobts900", - [GSM_BTS_TYPE_NANOBTS_1800] = "nanobts1800", + [GSM_BTS_TYPE_NANOBTS] = "nanobts", }; enum gsm_bts_type parse_btstype(const char *arg) diff --git a/openbsc/src/ipaccess-config.c b/openbsc/src/ipaccess-config.c index 7358d64..46043d5 100644 --- a/openbsc/src/ipaccess-config.c +++ b/openbsc/src/ipaccess-config.c @@ -348,7 +348,7 @@ int main(int argc, char **argv) if (!gsmnet) exit(1); - bts = gsm_bts_alloc(gsmnet, GSM_BTS_TYPE_NANOBTS_900, HARDCODED_TSC, + bts = gsm_bts_alloc(gsmnet, GSM_BTS_TYPE_NANOBTS, HARDCODED_TSC, HARDCODED_BSIC); register_signal_handler(SS_NM, nm_sig_cb, NULL); -- 1.6.0.4 --------------020006030004070001070807--

1 0

Patch: parsing of Software Activate parameters
by Mike Haben 01 Oct '09

01 Oct '09

Hi all, Patch-file is attached - addresses a FIXME in abis_nm.c, parsing the parameters passed by a Software Activate request. I've tested this on three different IpAccess BTSs (including one which didn't work with the original code), would be good if someone could check it on a BS11. Best regards, Mike H.

3 2

[RFC] Changes to the lchan and BSC/MSC split
by Holger Freyther 01 Oct '09

01 Oct '09

Hey guys, back in January I added ref-counting to the lchan and it has worked to some degree, and we have seen ref-leaks as well (fixed thanks to Andreas). Currently I'm working on integrating OpenBSC into a real MSC at on-waves.com and this has made me read the GSM08.08 specification a bit more. I would like to implement the following. - Remove the refcount from lchan - Replace it with the "transaction" concept. On certain 04.08 messgaes (e.g. paging response, various MM messages) open a transaction from BSC to MSC code. The channel is bound to the transaction. The lchan is getting released when the transaction is finished, in case of the "RSL chan" is going away too early there will be a "clear" signal/method called from the BSC and the MSC side is asked to let it go. The benefit of this: - BSC and MSC are better separated - My MSC code could wrap the transaction into a SCCP connection - Channel leak == transaction_free not getting called. regards holger

3 4

LAC 0 / paging to all BTS
by Harald Welte 01 Oct '09

01 Oct '09

Hi Zecke, I've been reviewing some of your patches: > commit 45f9b3d3fc47074652be951eb74df2b0be2a230f > Author: Holger Hans Peter Freyther <zecke(a)selfish.org> > Date: Fri Aug 21 05:30:19 2009 +0200 > > [paging] Use one of the two reserved LAC to page every BTS > > For the on-waves.com MSC case we want to page every BTS reached > of the network. Our gsm_subscriber entry does not have a LAC > entry set and defaults to zero. Use the reserved 0x0000 to > indicate that we want to use every bts in the network. > > This will influence the paging code to start and stop paging. The problem is that in the current code, we use LAC == 0 to indicate that the subscriber has sent an IMSI DETACH message, i.e. switched his phone off. You are now redefiniing the LAC 0 to something like the opposite case, which I don't particularly like. Is there some alternative solution? Regards, -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 3

[PATCH] input/ipaccess: Fix segv caused by use of uninitialized var
by Sylvain Munaut 01 Oct '09

01 Oct '09

From: Sylvain Munaut <tnt(a)246tNt.com> This is a regression coming from the recent split of the handle_ts1_read method in two. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- openbsc/src/input/ipaccess.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/openbsc/src/input/ipaccess.c b/openbsc/src/input/ipaccess.c index 8a22810..40891ae 100644 --- a/openbsc/src/input/ipaccess.c +++ b/openbsc/src/input/ipaccess.c @@ -319,7 +319,7 @@ static int handle_ts1_read(struct bsc_fd *bfd) return error; } - DEBUGP(DMI, "RX %u: %s\n", ts_nr, hexdump(msgb_l2(msg), ret)); + DEBUGP(DMI, "RX %u: %s\n", ts_nr, hexdump(msgb_l2(msg), msgb_l2len(msg))); hh = (struct ipaccess_head *) msg->data; if (hh->proto == IPAC_PROTO_IPACCESS) { -- 1.6.4

2 1

OpenBSC, nanoBTS and Asterisk integration
by Sylvain Munaut 30 Sep '09

30 Sep '09

Hi, This week end I started coding a channel driver to integrate OpenBSC and Asterisk directly. You can find the code here http://github.com/smunaut/ast_chan_openbsc The current public version is what I coded this Saturday, it doesn't do much, only registers itself as a channel driver and runs the openBSC core within asterisk. It will work only for the ip.access at first (at least) because I'm directly bridging the RTP audio from the nanoBTS to the RTP subsystem of Asterisk. I spent a good part of today hacking together enough code to make a call and it worked, I got bidirectional audio. This latest code is not public yet because it's just a big mess and only take care of setup and not cleanup (so you can do 1 call and then restart :) With this hack, I just wanted to confirm that it could work without too much problem. I will try to clean it up ASAP and publish it so that there is a minimal functionality testable :) OTOH, my time is limited and I split it between OpenBSC, OpenBTS and airprobe so some weeks may be slow. Sylvain

2 5

Quick & Dirty test of the ciphering functions
by Sylvain Munaut 28 Sep '09

28 Sep '09

Hi everyone, This evening I spent a few hours hacking a small test to activate ciphering and I tought people might be interested with tinkering with it. If you want to try for yourself, start off from the encryption branch of Harald, then apply the 4 patches I just posted to this list then apply the quick hack attached to this message. This patch is not for merge since it's a gross hack just 'to see if it works', and it does ! ( See the log in attachment ) What this patch does is pretty simple: - When there is a location update, it does a AUTHENTICATION REQUEST with a static RAND. - When the AUTHENTICATION RESPONSE is received, it compares the result with the 'known expected' results (see the wiki for AT commands to get SRES and Kc for a given RAND) - When sending a SMS to the MS, it activates the ciphering after receiving the paging response with the 'known precomputed' Kc. If everything goes well, the ME sends back a CIPHER MODE COMPLETE and the rest of the talk is ciphered. The included patch uses A5/2 but can be trivially modified for A5/1. I just wanted to see if the iPhone would accept A5/2 and it doesn't (works with A5/1 tough) ! My old Ericsson T610 takes A5/2 and A5/1. Of course, this is no where near a good implementation but at least it provides proof that the lower level functions works. I'm not sure what's the best solution to get SRES and Kc. Most of the time getting the Ki is not an option, so either we have a fixed RAND, or a bunch RAND and corresponding SRES and Kc ... Or a side channel to run the algo on the phone itself ... Sylvain

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC