RFC: Change gsm_subscriber tmsi from char[17] to u_int32_t
Hey guys, for some historic reason our tmsi is an character array but all places dealing with it treat it as a 4 octet, and according to the spec it is a four octet. I have changed the definition and the code using the tmsi. It can be found in my onwaves.com branch. Does it make sense to switch? z.
Holger Freyther schreef:
Hey guys,
for some historic reason our tmsi is an character array but all places dealing with it treat it as a 4 octet, and according to the spec it is a four octet. I have changed the definition and the code using the tmsi. It can be found in my onwaves.com branch.
Does it make sense to switch?
It seems fine to me :)
On Thu, Aug 20, 2009 at 11:30:20AM +0200, Holger Freyther wrote:
Hey guys,
for some historic reason our tmsi is an character array but all places dealing with it treat it as a 4 octet, and according to the spec it is a four octet. I have changed the definition and the code using the tmsi. It can be found in my onwaves.com branch.
yes, please change. I was actually surprised that it's not a u_int32_t. I think in the database it is useful to have it as a string, though. at least if you want to manually search for it without any frontend software. -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (3)
-
Harald Welte -
Holger Freyther -
Nordin