OpenBSC

openbsc@lists.osmocom.org

14 participants
4198 discussions

AW: patch: fix of compiler warnings
by Andreas.Eversberg 17 Nov '09

17 Nov '09

i am not sure, if the variables bts and trx will be used in the future, so i left them as comments. -----Ursprüngliche Nachricht----- Von: openbsc-bounces(a)lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] Im Auftrag von Holger Freyther Gesendet: Dienstag, 17. November 2009 10:20 An: openbsc(a)lists.gnumonks.org Betreff: Re: patch: fix of compiler warnings On Monday 16 November 2009 18:52:32 Andreas.Eversberg wrote: > diff --git a/openbsc/src/bsc_init.c b/openbsc/src/bsc_init.c > index 815fe2b..3b451b1 100644 > --- a/openbsc/src/bsc_init.c > +++ b/openbsc/src/bsc_init.c > @@ -433,8 +433,8 @@ int nm_state_event(enum nm_evt evt, u_int8_t > obj_class, void *obj, > static int sw_activ_rep(struct msgb *mb) > { > struct abis_om_fom_hdr *foh = msgb_l3(mb); > - struct gsm_bts *bts = mb->trx->bts; > - struct gsm_bts_trx *trx = gsm_bts_trx_num(bts, > foh->obj_inst.trx_nr); > +// struct gsm_bts *bts = mb->trx->bts; > +// struct gsm_bts_trx *trx = gsm_bts_trx_num(bts, > foh->obj_inst.trx_nr); was this intentional? Is the warning that these are unused? In this case we will just nuke the variable declaration.

1 0

patch: fix of paging result issue
by Andreas.Eversberg 17 Nov '09

17 Nov '09

hi, one of my nokia phones 6310i: V 04.20 04-03-02 NPE-4 (c) NPM. when the subscriber is paged, the phone will answer with "CHREQ_T_PAG_R_ANY" value (ra=0x83). because the phone does not tell use what it wants, i must assume that there may be a need for a traffic channel. without this patch, the call will be made with wrong channel type: <0200> paging.c:113 Going to send paging commands: imsi: '262XXXXXXXXXXX' tmsi: '0x3044ea7a' <0010> abis_rsl.c:1179 Activating ARFCN(121) TS(0) SS(0) lctype SDCCH chan_nr=0x20 r=PAGING ra=0x83 can we figure out which subscriber did the channel request? if so, we can check what channel type is required. (we can look through the transactions and select the required channel type. if a transaction with higher rate is paging, we can assign this channel type.) any ideas? regards, andreas diff --git a/openbsc/src/gsm_04_08_utils.c b/openbsc/src/gsm_04_08_utils.c index 6ffb109..2c30d13 100644 --- a/openbsc/src/gsm_04_08_utils.c +++ b/openbsc/src/gsm_04_08_utils.c @@ -283,7 +283,7 @@ static const enum gsm_chan_t ctype_by_chreq[] = { [CHREQ_T_VOICE_CALL_TCH_H] = GSM_LCHAN_TCH_H, [CHREQ_T_DATA_CALL_TCH_H] = GSM_LCHAN_TCH_H, [CHREQ_T_LOCATION_UPD] = GSM_LCHAN_SDCCH, - [CHREQ_T_PAG_R_ANY] = GSM_LCHAN_SDCCH, + [CHREQ_T_PAG_R_ANY] = GSM_LCHAN_TCH_F, [CHREQ_T_PAG_R_TCH_F] = GSM_LCHAN_TCH_F, [CHREQ_T_PAG_R_TCH_FH] = GSM_LCHAN_TCH_F, };

2 1

patch: fix of configuration file generation
by Andreas.Eversberg 17 Nov '09

17 Nov '09

this patches fixes the generation of the config file. after saving of configuration, no location update was possible anymore. it is self explaining... diff --git a/openbsc/src/vty_interface.c b/openbsc/src/vty_interface.c index 9aa9706..c6e60c0 100644 --- a/openbsc/src/vty_interface.c +++ b/openbsc/src/vty_interface.c @@ -784,7 +784,7 @@ DEFUN(cfg_net_encryption, "encryption a5 (0|1|2)", "Enable or disable encryption (A5) for this network\n") { - gsmnet->auth_policy = atoi(argv[0]); + gsmnet->a5_encryption = atoi(argv[0]); return CMD_SUCCESS; }

2 1

tests with subscriber usage
by Andreas.Eversberg 17 Nov '09

17 Nov '09

hi, i did may tests with the "holger/subscr-ref-handling" branch. i had no subscriber usage leak within may hours of testing. about hunded calls were made with many out-of-range failures, hold/retrieve, and battery removal during call. at the end, all subscribers usage returned back to 0. i did not test SMS, just location updates and voice calls. regards, andreas

2 1

patch: subscriber usage debug
by Andreas.Eversberg 17 Nov '09

17 Nov '09

this patch will give more detailed debug information about subscriber usage. when subcriber structure is allocated, it will be shown on debug output. subscr_get() and subscr_put() debug will also show the calling function for better understanding. diff --git a/openbsc/include/openbsc/gsm_subscriber.h b/openbsc/include/openbsc/gsm_subscriber.h index d612ed5..02e193a 100644 --- a/openbsc/include/openbsc/gsm_subscriber.h +++ b/openbsc/include/openbsc/gsm_subscriber.h @@ -71,8 +71,10 @@ enum gsm_subscriber_update_reason { GSM_SUBSCRIBER_UPDATE_EQUIPMENT, }; -struct gsm_subscriber *subscr_get(struct gsm_subscriber *subscr); -struct gsm_subscriber *subscr_put(struct gsm_subscriber *subscr); +#define subscr_get(subscr) _subscr_get(__FUNCTION__, subscr) +struct gsm_subscriber *_subscr_get(const char *func, struct gsm_subscriber *subscr); +#define subscr_put(subscr) _subscr_put(__FUNCTION__, subscr) +struct gsm_subscriber *_subscr_put(const char *func, struct gsm_subscriber *subscr); struct gsm_subscriber *subscr_get_by_tmsi(struct gsm_network *net, u_int32_t tmsi); struct gsm_subscriber *subscr_get_by_imsi(struct gsm_network *net, @@ -87,7 +89,8 @@ void subscr_get_channel(struct gsm_subscriber *subscr, int type, gsm_cbfn *cbfn, void *param); /* internal */ -struct gsm_subscriber *subscr_alloc(void); +#define subscr_alloc() _subscr_alloc(__FUNCTION__) +struct gsm_subscriber *_subscr_alloc(const char *func); extern struct llist_head active_subscribers; #endif /* _GSM_SUBSCR_H */ diff --git a/openbsc/src/gsm_subscriber_base.c b/openbsc/src/gsm_subscriber_base.c index bcf55d1..7fe2f21 100644 --- a/openbsc/src/gsm_subscriber_base.c +++ b/openbsc/src/gsm_subscriber_base.c @@ -113,7 +113,7 @@ static void subscr_send_paging_request(struct gsm_subscriber *subscr) } } -struct gsm_subscriber *subscr_alloc(void) +struct gsm_subscriber *_subscr_alloc(const char *func) { struct gsm_subscriber *s; @@ -123,6 +123,8 @@ struct gsm_subscriber *subscr_alloc(void) memset(s, 0, sizeof(*s)); llist_add_tail(&s->entry, &active_subscribers); + DEBUGP(DCC, "(from %s) new subscr allocated, setting usage to: 1\n", + func); s->use_count = 1; s->tmsi = GSM_RESERVED_TMSI; @@ -137,19 +139,19 @@ static void subscr_free(struct gsm_subscriber *subscr) talloc_free(subscr); } -struct gsm_subscriber *subscr_get(struct gsm_subscriber *subscr) +struct gsm_subscriber *_subscr_get(const char *func, struct gsm_subscriber *subscr) { subscr->use_count++; - DEBUGP(DCC, "subscr %s usage increases usage to: %d\n", - subscr->extension, subscr->use_count); + DEBUGP(DCC, "(from %s) subscr %s usage increases usage to: %d\n", + func, subscr->extension, subscr->use_count); return subscr; } -struct gsm_subscriber *subscr_put(struct gsm_subscriber *subscr) +struct gsm_subscriber *_subscr_put(const char *func, struct gsm_subscriber *subscr) { subscr->use_count--; - DEBUGP(DCC, "subscr %s usage decreased usage to: %d\n", - subscr->extension, subscr->use_count); + DEBUGP(DCC, "(from %s) subscr %s usage decreased usage to: %d\n", + func, subscr->extension, subscr->use_count); if (subscr->use_count <= 0) subscr_free(subscr); return NULL;

2 1

AW: patch: fix of compiler warnings
by Andreas.Eversberg 17 Nov '09

17 Nov '09

there is an error in this patch: + if (found < 0) { this is correct: + if (!found) {

1 0

GPRS branch status update
by Harald Welte 16 Nov '09

16 Nov '09

Hi! I've applied a series of fixes and extensions to the GPRS branch, and would like to invited interested nanoBTS users to give it another try. Right now, I am getting fully through GPRS routing area update and attach request, i.e. the phones can fully register to the GPRS network. Minimal PDP context activation and deactivation has been implemented, i.e. the phone will send a ACTIVATE PDP CONTEXT REQUEST, and the network will simply ACK it. However, since the network does not add any IPCP options, the phone will typically DEACTIVATE the context immediately after that. Have fun, -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

3 3

Unable to compile because of missing dbi/dbi.h
by ನಾಗೇಶ್ 14 Nov '09

14 Nov '09

Hi, I am trying to compile the source code but, I am stuck with the dbi.h header file. Where can I get this include file so that I can successfully compile ? N.

3 2

nanoBTS transmit power
by Bjoern Heller 14 Nov '09

14 Nov '09

Hi, how do I configure the nanoBTS transmit power? regards Björn - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Björn Heller Jabber: tec(a)jabber.hellercom.de

2 1

Unable to do menuconfig.
by ನಾಗೇಶ್ 13 Nov '09

13 Nov '09

Hi, I am following instruction from this page : http://openbsc.gnumonks.org/trac/wiki/Debian_Getting_Started When I do make menuconfig I get to the point until I have to select the mISDN modules. Firstly, I had to download the 2.6.31.6 kernel which is different as described in the page above. And, secondly, when I do select (based on the best 'guess'), there is no change at all ! I am forced to select 'Exit' - it does not proceed further. Is there anything you would like to suggest ? I am running minimal Ubuntu Linux (https://help.ubuntu.com/community/Installation/MinimalCD) as a guest OS using VirtualBox hosted on Ubuntu 9.10. N.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC