OpenBSC

openbsc@lists.osmocom.org

11 participants
4278 discussions

[PATCH] tests: timer: add parameter to select the number of steps
by Pablo Neira Ayuso 13 Nov '11

13 Nov '11

Holger likes having a parameter to set the number of steps in this test. Now you can set it via `-s' option. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- tests/timer/timer_test.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index bcaafdb..a01a9e5 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <stdlib.h> +#include <getopt.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> @@ -60,6 +61,7 @@ struct test_timer { #define TIMER_PRES_SECS 0 #define TIMER_PRES_USECS 10000 +static int timer_nsteps = MAIN_TIMER_NSTEPS; static unsigned int expired_timers = 0; static unsigned int total_timers = 0; static unsigned int too_late = 0; @@ -70,7 +72,7 @@ static void main_timer_fired(void *data) unsigned int add_in_this_step; int i; - if (*step == MAIN_TIMER_NSTEPS) { + if (*step == timer_nsteps) { printf("Main timer has finished, please, wait a bit for the " "final report.\n"); return; @@ -134,11 +136,28 @@ static void secondary_timer_fired(void *data) } } -int main(int argc, char** argv) +int main(int argc, char *argv[]) { + int c; + + while ((c = getopt_long(argc, argv, "s:", NULL, NULL)) != -1) { + switch(c) { + case 's': + timer_nsteps = atoi(optarg); + if (timer_nsteps <= 0) { + fprintf(stderr, "%s: steps must be > 0\n", + argv[0]); + exit(EXIT_FAILURE); + } + break; + default: + exit(EXIT_FAILURE); + } + } + printf("Running timer test for %u steps, accepting imprecision " "of %u.%.6u seconds\n", - MAIN_TIMER_NSTEPS, TIMER_PRES_SECS, TIMER_PRES_USECS); + timer_nsteps, TIMER_PRES_SECS, TIMER_PRES_USECS); osmo_timer_schedule(&main_timer, 1, 0); -- 1.7.2.5 --k1lZvvs/B4yU6o8G--

1 0

[PATCH] timer: fix active timer re-scheduling situation
by Pablo Neira Ayuso 13 Nov '11

13 Nov '11

This patch re-adds support the timer re-scheduling situation which used to be supported until I introduced the rb-tree based timer. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- src/timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/timer.c b/src/timer.c index 6852983..e68040f 100644 --- a/src/timer.c +++ b/src/timer.c @@ -68,6 +68,7 @@ static void __add_timer(struct osmo_timer_list *timer) */ void osmo_timer_add(struct osmo_timer_list *timer) { + osmo_timer_del(timer); timer->active = 1; INIT_LLIST_HEAD(&timer->list); __add_timer(timer); -- 1.7.2.5 --FCuugMFkClbJLl1L--

1 0

LCR + Asterisk + NanoBTS: Strange Voice Behaviour "Dropping incompatible voice frame on lcr/1"
by Luca Bongiorni 09 Nov '11

09 Nov '11

Hi all, i compiled and configured all (mISDN, lcr, asterisk, etc...), unfortunately, when i try to place a call from the softphone to the MS, i can ear only the voice originated from the laptop to the MS and not viceversa. I'm using it on an Ubuntu 10.4, Asterisk 1.6.2.5 and the others sources from "last git". Configurations: - extension.conf: http://pastebin.com/mHH46HbQ - sip.conf: http://pastebin.com/SkPN3z6q - gsm.conf: http://pastebin.com/C1Eckdgh - interface.conf: http://pastebin.com/ctGapa1F - options.conf: http://pastebin.com/6xhgL0P1 - routing.conf: http://pastebin.com/TVNvwTEB Logs: - osmo-nitb's log: http://pastebin.com/X10B5NjE - lcr's log: http://pastebin.com/uLY9VAiB - Asterisk's log: http://pastebin.com/8qzw6aMn As you can see from Asterisk, there is a mismatch: "NOTICE[2315]: channel.c:2960 __ast_read: Dropping incompatible voice frame on lcr/1 of format alaw since our native format has changed to 0x0 (nothing) " I tried to set alaw / ulaw on the configurations, to change efr, fr and amr, but it didn't change nothing. Ideas or hints for further investigations are welcome. Regards, Luca

4 6

[RFC] MNCC introduce a hello packet to include a version number
by Holger Hans Peter Freyther 01 Nov '11

01 Nov '11

Hi Jolly, all, I spent some time figuring out why LCR and OpenBSC wouldn't want to work with each other. The reason was the addition of an element to the MNCC structure. I propose to send a hello packet down the MNCC socket and leave it to the client to decide if the version is acceptable. I will need to move the mncc header to libosmocore as osmocomBB is currently using a copy of the OpenBSC header. comments holger

2 2

OpenBSC implementation problem
by Marek Świąder 28 Oct '11

28 Oct '11

Dear Sir or Madam, We are students from Poznan University of Technology in Poland.We want to develop our GUI enhancement for OpenBSC project.It's about adding and deleting users registered in network. We have already implemented adding logged users, but we couldn't make this part of program, which is responsible for deleting users when they have already logged out. Could you give some advice, where to find appropriate place in the source code in OpenBSC. Thanks in advance. Best regards Marek Świąder

2 1

Looking for a CSN.1 library
by Alexander Chemeris 27 Oct '11

27 Oct '11

Hi all, Does anyone know a good C/C++ library for CSN.1 bitstream reading/writing? We're working on a GPRS implementation for OpenBTS and we don't want to code all those RLC/MAC messages by hands when we can do this automatically. Right now we think that the easiest way is to re-purpose csn1 "library" from Wireshark - adopt it to OpenBTS bitstream operations and add support for writing to bitstream. Then we can even re-use those RLC/MAC messages already converted to macros' for Wireshark's rlcmac dissector. But we would appreciate if someone points us to a better way of doing this. -- Regards, Alexander Chemeris.

4 5

how to know GPRS channel coding
by John Wu 27 Oct '11

27 Oct '11

Hi all, I want to know how to know GPRS channel coding. GPRS using PDCH, both MAC/RLC data block and MAC/RLC control block is transmitted on PDCH, although there is PACCH, PTCH, PTCCH and so on it still PDCH. then the MAC/RLC control block is coded with cs-1 channel coding scheme and MAC/RLC data block may be coded with other channel coding scheme. so when received a burst how to know what kind of MAC/RLC block it belong to and which channel coding scheme it used? Thanks!

2 1

Way to invoke multiple imsi msisdn in sgnsemu
by anish achenkunju 21 Oct '11

21 Oct '11

Hi All, Wondering if there is a way to create pdp request for multple imsi or msisdn. Currently there is an option to emulate more than one pdp context, can we do the same for different imsi's or msisdn via sgsnemu as an input to sgsnemu.conf file? Thank you in advance. Anish

2 2

[PATCH] mncc: Introduce a hello packet that is sent to the client.
by Holger Hans Peter Freyther 21 Oct '11

21 Oct '11

Send a hello packet down to the client with the version number of the MNCC interface. The hello structure might be extended to include the endianes, size of each structure, etc. --- openbsc/include/openbsc/mncc.h | 8 ++++++++ openbsc/src/libmsc/mncc_sock.c | 24 ++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/openbsc/include/openbsc/mncc.h b/openbsc/include/openbsc/mncc.h index 8c59fe2..9153d65 100644 --- a/openbsc/include/openbsc/mncc.h +++ b/openbsc/include/openbsc/mncc.h @@ -96,6 +96,8 @@ struct gsm_call { #define GSM_TCHF_FRAME 0x0300 #define GSM_TCHF_FRAME_EFR 0x0301 +#define MNCC_SOCKET_HELLO 0x0400 + #define GSM_MAX_FACILITY 128 #define GSM_MAX_SSVERSION 128 #define GSM_MAX_USERUSER 128 @@ -158,6 +160,12 @@ struct gsm_data_frame { unsigned char data[0]; }; +#define MNCC_SOCK_VERSION 1 +struct gsm_mncc_hello { + uint32_t msg_type; + uint32_t version; +}; + char *get_mncc_name(int value); void mncc_set_cause(struct gsm_mncc *data, int loc, int val); void cc_tx_to_mncc(struct gsm_network *net, struct msgb *msg); diff --git a/openbsc/src/libmsc/mncc_sock.c b/openbsc/src/libmsc/mncc_sock.c index d8caf07..b9ebdb0 100644 --- a/openbsc/src/libmsc/mncc_sock.c +++ b/openbsc/src/libmsc/mncc_sock.c @@ -213,6 +213,29 @@ static int mncc_sock_cb(struct osmo_fd *bfd, unsigned int flags) return rc; } +/** + * Send a version indication to the remote. + */ +static void queue_hello(struct mncc_sock_state *mncc) +{ + struct gsm_mncc_hello *hello; + struct msgb *msg; + + msg = msgb_alloc(512, "mncc hello"); + if (!msg) { + LOGP(DMNCC, LOGL_ERROR, "Failed to allocate hello.\n"); + mncc_sock_close(mncc); + return; + } + + hello = (struct gsm_mncc_hello *) msgb_put(msg, sizeof(*hello)); + hello->msg_type = MNCC_SOCKET_HELLO; + hello->version = MNCC_SOCK_VERSION; + + msgb_enqueue(&mncc->net->upqueue, msg); + mncc->conn_bfd.when |= BSC_FD_WRITE; +} + /* accept a new connection */ static int mncc_sock_accept(struct osmo_fd *bfd, unsigned int flags) { @@ -253,6 +276,7 @@ static int mncc_sock_accept(struct osmo_fd *bfd, unsigned int flags) LOGP(DMNCC, LOGL_NOTICE, "MNCC Socket has connection with external " "call control application\n"); + queue_hello(state); return 0; } -- 1.7.5.4 --------------020402070302030203020301 Content-Type: text/x-patch; name="0001-gsm-Verify-the-MNCC_VERSION-of-the-BSC-MS-and-close-.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-gsm-Verify-the-MNCC_VERSION-of-the-BSC-MS-and-close-.pa"; filename*1="tch"

1 0

[PATCH] gsm: Verify the MNCC_VERSION of the BSC/MS and close the socket on mismatch
by Holger Hans Peter Freyther 21 Oct '11

21 Oct '11

The BSC/MS will send a Hello packet that includes the version number, make LCR verify this version number and close the socket in case it does not match a supported version. --- gsm.cpp | 12 ++++++++++++ mncc.h | 7 +++++++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/gsm.cpp b/gsm.cpp index e6806c3..227d618 100644 --- a/gsm.cpp +++ b/gsm.cpp @@ -1042,6 +1042,7 @@ static int mncc_fd_read(struct lcr_fd *lfd, void *inst, int idx) int rc; static char buf[sizeof(struct gsm_mncc)+1024]; struct gsm_mncc *mncc_prim = (struct gsm_mncc *) buf; + struct gsm_mncc_hello *hello = (struct gsm_mncc_hello *) buf; memset(buf, 0, sizeof(buf)); rc = recv(lfd->fd, buf, sizeof(buf), 0); @@ -1050,6 +1051,17 @@ static int mncc_fd_read(struct lcr_fd *lfd, void *inst, int idx) if (rc < 0) return rc; + /* TODO: size check? */ + switch (mncc_prim->msg_type) { + case MNCC_SOCKET_HELLO: + if (hello->version != MNCC_SOCK_VERSION) { + PERROR("MNCC version different. BSC version is %u\n", hello->version); + mncc_fd_close(lcr_gsm, lfd); + return 0; + } + break; + } + /* Hand the MNCC message into LCR */ switch (lcr_gsm->type) { #ifdef WITH_GSM_BS diff --git a/mncc.h b/mncc.h index e5f8216..fac7145 100644 --- a/mncc.h +++ b/mncc.h @@ -56,6 +56,8 @@ #define GSM_TCHF_FRAME 0x0300 #define GSM_TCHF_FRAME_EFR 0x0301 +#define MNCC_SOCKET_HELLO 0x0400 + #define GSM_MAX_FACILITY 128 #define GSM_MAX_SSVERSION 128 #define GSM_MAX_USERUSER 128 @@ -185,3 +187,8 @@ struct gsm_data_frame { unsigned char data[0]; }; +#define MNCC_SOCK_VERSION 1 +struct gsm_mncc_hello { + u_int32_t msg_type; + u_int32_t version; +}; -- 1.7.5.4 --------------020402070302030203020301--

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC