OpenBSC

openbsc@lists.osmocom.org

12 participants
4278 discussions

[PATCH] ipaccess: fix leak of e1inp_line
by Pablo Neira Ayuso 22 Aug '12

22 Aug '12

Holger reported a leak in the ipaccess_drop path and a patch to fix this. This is a new version of the patch posted that also handle the case in which only one of the link (OML / RSL) is established and no ID_RESP was received. Based on patch of Holger Freyther. --- src/e1_input.c | 1 + src/input/hsl.c | 4 +--- src/input/ipaccess.c | 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/e1_input.c b/src/e1_input.c index 957b74c..a85dd91 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -486,6 +486,7 @@ void e1inp_sign_link_destroy(struct e1inp_sign_link *link) if (link->ts->line->driver->close) link->ts->line->driver->close(link); + e1inp_line_put(link->ts->line); talloc_free(link); } diff --git a/src/input/hsl.c b/src/input/hsl.c index 3dcba1d..b86d7f6 100644 --- a/src/input/hsl.c +++ b/src/input/hsl.c @@ -82,10 +82,8 @@ static void hsl_drop(struct e1inp_line *line, struct osmo_fd *bfd) osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; + e1inp_line_put(line); } - /* put the virtual E1 line that we cloned for this socket, if - * it becomes unused, it gets released. */ - e1inp_line_put(line); } static int process_hsl_rsl(struct msgb *msg, struct e1inp_line *line, diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 76d1994..4c50640 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -248,10 +248,8 @@ static int ipaccess_drop(struct osmo_fd *bfd) close(bfd->fd); bfd->fd = -1; ret = -ENOENT; + e1inp_line_put(line); } - /* put the virtual E1 line that we cloned for this socket, if - * it becomes unused, it gets released. */ - e1inp_line_put(line); return ret; } -- 1.7.10.4 --OgqxwSJOaUobr8KG--

1 0

OpenGGSN over OpenBSC+LCR+Asterisk
by Arturo Rivas 22 Aug '12

22 Aug '12

Hi list! I have a working installation of OpenBSC+LCR+Asterisk in my system and now, I want to install OpenGGSN in addiction. I am trying tutorial of the next link: http://openbsc.osmocom.org/trac/wiki/OpenBSC_GPRS and I don't know if the new compilation of osmo-nitb will crash previous installation. I think that I have to install new programs in the same location where previous are but if I am not sure about because this could crash it. Thank you! Arturo Rivas.

3 2

Aug 22, 8pm / Osmocom Berlin User Group meeting
by Harald Welte 21 Aug '12

21 Aug '12

Hi all! This is the announcement for the next Osmocom Berlin meeting. Aug 22, 8pm @ CCC Berlin, Marienstr. 11, 10113 Berlin There is no formal presentation scheduled for this meeting. However, updates will be provided on various current developments, such as * Progress on the CC32RS512 smart card (osmo-cos) * Possibly: Status of current attempts to get CSD implemented in OpenBSC If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

libosmo-sccp and static archives
by Diego Elio Pettenò 12 Aug '12

12 Aug '12

Hello, I was going on with the autotools cleanup (in order of listing in cgit) but I'm a bit surprised about the libosmo-sccp structure, which contrarily to libosmocore, libosmo-abis and libosmo-dsp is not using libtool, but it's actually building three static archives, with one source file each. Now, I don't know if it might be too late to consider changing this but I'm wondering why it has been done this way; when using a shared object it might make sense (although the overhead of using more than one object is probably higher than loading the unused code), but with static archives all the Unix link editors I know only take by default only the objects that are actually needed by what it's being linked; that is using a single libosmo-sccp.a will only bring in the final linking the object files that are actually needed. I also wonder if it wouldn't make more sense to have everything built in the same project/source tree with libosmocore — in general this seems to be small enough, and the time/space spent for these three files is probably well recovered by the extra ./configure run that it has to run. Let me know if I can be of help — I'll still send the autotools cleanup for this project today I think. -- Diego Elio Pettenò — Flameeyes flameeyes(a)flameeyes.eu — http://blog.flameeyes.eu/

3 4

Re: Any interest for Osmocom meetings in Bavaria ?
by Dieter Spaar 09 Aug '12

09 Aug '12

Hello Alexander, On Wed, 8 Aug 2012 20:44:12 +0400, "Alexander Chemeris" <alexander.chemeris(a)gmail.com> wrote: > > I'd love to join, but it strongly depends on the exact dates of the > meeting. I have very tight travel schedule in the next months. Just to avoid any misunderstanding: Those meetings are not supposed to be something similar to the Osmocom Developer Conference earlier this year. The idea is to have a regular or "on demand" oportunity to meet with people for a few hours and demonstrate or talk about the Osmocom projects or share new ideas. Its comparable to the regular Berlin meetings, you can get an idea of what goes on there: http://openbsc.osmocom.org/trac/blog/osmug-20120808 Of course you can attend, if you are close (Munich airport is 120 km away) but I would expect that Berlin is more convenient if you come from really far away and Berlin already has regular meetings. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

1 0

Re: Any interest for Osmocom meetings in Bavaria ?
by Dieter Spaar 09 Aug '12

09 Aug '12

As a quick follow up: The proposal for the meeting is intended for everyone interested in the various Osmocom projects (e.g. OpenBSC, OsmocomBB, TETRA, SimTrace, OsmoSDR). The meeting is not limited to only those who are actively participating. I will wait until next week to see how many people are interested, so far I am aware of two persons. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

2 1

Any interest for Osmocom meetings in Bavaria ?
by Dieter Spaar 07 Aug '12

07 Aug '12

I would like to ask if there is interest to have some kind of Osmocom meetings in Bavaria. Suggested location is here at my place in the south-east of Bavaria near Pfarrkirchen. There are no large cities close, but the location is still in reach with a car, some examples (single distance): - from Munich: 130 km - from Passau: 55 km - from Salzburg: 90 km - from Linz: 140 km Why at my place ? There is some GSM/3G/TETRA equipment and RF measurement gear around which could be demonstrated. It is not yet decided when and how (regular or "on demand") this meeting should take place. Before that I want to find out if there is interest at all and how many people are interested. So please write to the list what you think. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

1 0

Re: August 8, 8pm / Osmocom meeting in Berlin
by Harald Welte 07 Aug '12

07 Aug '12

Hi Matihas, On Mon, Aug 06, 2012 at 11:17:27PM +0200, Mathias K. wrote: > Where is the conference number? ;-). It would be nice to meet this > event virtually for none berlin citizens. Sorry, I don't really like the idea of having an unknown number of people listening in on conversations we have face to face. > Maybe there is some planning, maybe there is no reason/possibility to > do that. But there are some interesting topics that i want to hear, > maybe discuss. I suggest that you post any comments / questions / topics to the respective mailing lists. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

August 8, 8pm / Osmocom meeting in Berlin
by Harald Welte 06 Aug '12

06 Aug '12

Hi all! This is the announcement for the next Osmocom Berlin meeting. Aug 08, 8pm @ CCC Berlin, Marienstr. 11, 10113 Berlin Harald will be giving a short presentation on contemporary smartphone hardware architecture. Furthermore, updates and discussions on various current developments will be exchanged, such as * Demo of OsmoPCU on sysmoBTS * Status of new SMSC * Planning phase of custom calypso board If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Updates and the blog post can be found here: http://openbsc.osmocom.org/trac/blog/osmug-20120808 -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

[PATCH] Add missing includes to timer_test.c and osmo-auc-gen.c
by Chí-Thanh Christopher Nguyễn 03 Aug '12

03 Aug '12

This fixes the build with -Werror-implicit-function-declaration. --- tests/timer/timer_test.c | 1 + utils/osmo-auc-gen.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index 61079bd..ba3127d 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -26,6 +26,7 @@ #include <stdlib.h> #include <signal.h> #include <getopt.h> +#include <unistd.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 266d0d6..1a78477 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -26,6 +26,7 @@ #include <errno.h> #include <string.h> #include <getopt.h> +#include <time.h> #include <osmocom/crypt/auth.h> #include <osmocom/core/utils.h> -- 1.7.8.6

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC