OpenBSC

openbsc@lists.osmocom.org

12 participants
4278 discussions

OsmoDevCon 2013 brainstorming
by Harald Welte 04 Jan '13

04 Jan '13

Hi all, as the year 2012 has already ended or will soon end depending on your timezone, it might be a good occasion to start thinking of an OsmoDevCon 2013. I personally percevied OsmoDevCon 2012 as a big success, and it was fun to bring everyone together. Generally, I prefer to keep the spirit of an invitation-only developer+contributor-only event of those involved in Osmocom. At the same time, I would consider it a good idea to add a one day user-conference to the schedule, where we try to get interested users up to speed with the various projects, possibly including some workshops and the like. So schedule-wise, I would suggest something like: * one day user conference * two day developer/contributor event * optionally: 1-2 "hacking days". The concept of "hacking days" has proven to be quite useful for the netfilter project in the past (Pablo and I can acknowledge to that fact). I'm not sure how many people would be able to spend even more days of their schedule, but even if it's a much smaller group it would still be useful, IMHO. I'd like you to 1) provide feedback on the ideas about the one-day user event and the hacking days 2) consider whether late march (like 2012) would be a good schedule again 3) what we can improve from the last event In terms of improvements, I so far have noted down: * larger venue needs to be found * complaints about the venue not having sufficient heating Venue-wise, I would again suggest to hold it in Berlin, as it's reasonbly well connected, has lots of low-cost flights to it, accomodation is not too expensive and holger/me/sysmocom can take care of local organization related activities. Hoewver, if somebody has a strong opinion against berlin _and_ is willing to organize it, I'm not completely against another venue. Regards and happy new year, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

4 7

[PATCH] libosmocore osmo_revbytebits_buf stack trashing
by noselasd＠fiane.dyndns.org 03 Jan '13

03 Jan '13

Hi, The second loop in osmo_revbytebits_buf() in src/bits.c grabs 4 bytes each iteration, which can easily go past the supplied input in some cases. Compiled with -fstack-protector , I get a "stack smashing detected" in the bits test. Attached patch should deal with that.

2 1

[PATCH] libmsc: vty: Channel Requests statistics are already printed by openbsc_vty_print_statistics
by Jan Luebbe 28 Dec '12

28 Dec '12

From: Jan Luebbe <jluebbe(a)debian.org> We don't need the same line two times. --- openbsc/src/libmsc/vty_interface_layer3.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c index eeeb51f..2b70cad 100644 --- a/openbsc/src/libmsc/vty_interface_layer3.c +++ b/openbsc/src/libmsc/vty_interface_layer3.c @@ -728,9 +728,6 @@ DEFUN(show_stats, struct gsm_network *net = gsmnet_from_vty(vty); openbsc_vty_print_statistics(vty, net); - vty_out(vty, "Channel Requests : %lu total, %lu no channel%s", - osmo_counter_get(net->stats.chreq.total), - osmo_counter_get(net->stats.chreq.no_channel), VTY_NEWLINE); vty_out(vty, "Location Update : %lu attach, %lu normal, %lu periodic%s", osmo_counter_get(net->stats.loc_upd_type.attach), osmo_counter_get(net->stats.loc_upd_type.normal), -- 1.7.10.4

1 0

[PATCH] libmsc: vty: Channel Requests statistics are already printed by openbsc_vty_print_statistics
by Jan Luebbe 28 Dec '12

28 Dec '12

We don't need the same line two times. --- openbsc/src/libmsc/vty_interface_layer3.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c index eeeb51f..2b70cad 100644 --- a/openbsc/src/libmsc/vty_interface_layer3.c +++ b/openbsc/src/libmsc/vty_interface_layer3.c @@ -728,9 +728,6 @@ DEFUN(show_stats, struct gsm_network *net = gsmnet_from_vty(vty); openbsc_vty_print_statistics(vty, net); - vty_out(vty, "Channel Requests : %lu total, %lu no channel%s", - osmo_counter_get(net->stats.chreq.total), - osmo_counter_get(net->stats.chreq.no_channel), VTY_NEWLINE); vty_out(vty, "Location Update : %lu attach, %lu normal, %lu periodic%s", osmo_counter_get(net->stats.loc_upd_type.attach), osmo_counter_get(net->stats.loc_upd_type.normal), -- 1.7.10.4

1 0

[PATCH] gsm_subscriber: change subscr_bsc_active_subscriber to plural
by Jan Luebbe 26 Dec '12

26 Dec '12

This was requested by Holger Freyther <zecke(a)selfish.org>. --- openbsc/src/libbsc/gsm_subscriber_base.c | 10 +++++----- openbsc/src/libmsc/gsm_subscriber.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/openbsc/src/libbsc/gsm_subscriber_base.c b/openbsc/src/libbsc/gsm_subscriber_base.c index 11afb35..747a699 100644 --- a/openbsc/src/libbsc/gsm_subscriber_base.c +++ b/openbsc/src/libbsc/gsm_subscriber_base.c @@ -35,7 +35,7 @@ LLIST_HEAD(active_subscribers); void *tall_subscr_ctx; /* for the gsm_subscriber.c */ -struct llist_head *subscr_bsc_active_subscriber(void) +struct llist_head *subscr_bsc_active_subscribers(void) { return &active_subscribers; } @@ -95,7 +95,7 @@ struct gsm_subscriber *subscr_get_or_create(struct gsm_network *net, { struct gsm_subscriber *subscr; - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (strcmp(subscr->imsi, imsi) == 0 && subscr->net == net) return subscr_get(subscr); } @@ -113,7 +113,7 @@ struct gsm_subscriber *subscr_active_by_tmsi(struct gsm_network *net, uint32_t t { struct gsm_subscriber *subscr; - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (subscr->tmsi == tmsi && subscr->net == net) return subscr_get(subscr); } @@ -125,7 +125,7 @@ struct gsm_subscriber *subscr_active_by_imsi(struct gsm_network *net, const char { struct gsm_subscriber *subscr; - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (strcmp(subscr->imsi, imsi) == 0 && subscr->net == net) return subscr_get(subscr); } @@ -138,7 +138,7 @@ int subscr_purge_inactive(struct gsm_network *net) struct gsm_subscriber *subscr, *tmp; int purged = 0; - llist_for_each_entry_safe(subscr, tmp, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry_safe(subscr, tmp, subscr_bsc_active_subscribers(), entry) { if (subscr->net == net && subscr->use_count <= 0) { subscr_free(subscr); purged += 1; diff --git a/openbsc/src/libmsc/gsm_subscriber.c b/openbsc/src/libmsc/gsm_subscriber.c index f9eebc8..0889400 100644 --- a/openbsc/src/libmsc/gsm_subscriber.c +++ b/openbsc/src/libmsc/gsm_subscriber.c @@ -39,7 +39,7 @@ void *tall_sub_req_ctx; -extern struct llist_head *subscr_bsc_active_subscriber(void); +extern struct llist_head *subscr_bsc_active_subscribers(void); int gsm48_secure_channel(struct gsm_subscriber_connection *conn, int key_seq, gsm_cbfn *cb, void *cb_data); @@ -272,7 +272,7 @@ struct gsm_subscriber *subscr_get_by_tmsi(struct gsm_network *net, struct gsm_subscriber *subscr; /* we might have a record in memory already */ - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (tmsi == subscr->tmsi) return subscr_get(subscr); } @@ -286,7 +286,7 @@ struct gsm_subscriber *subscr_get_by_imsi(struct gsm_network *net, { struct gsm_subscriber *subscr; - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (strcmp(subscr->imsi, imsi) == 0) return subscr_get(subscr); } @@ -299,7 +299,7 @@ struct gsm_subscriber *subscr_get_by_extension(struct gsm_network *net, { struct gsm_subscriber *subscr; - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (strcmp(subscr->extension, ext) == 0) return subscr_get(subscr); } @@ -314,7 +314,7 @@ struct gsm_subscriber *subscr_get_by_id(struct gsm_network *net, char buf[32]; sprintf(buf, "%llu", id); - llist_for_each_entry(subscr, subscr_bsc_active_subscriber(), entry) { + llist_for_each_entry(subscr, subscr_bsc_active_subscribers(), entry) { if (subscr->id == id) return subscr_get(subscr); } -- 1.7.10.4

1 0

Please review and test zecke/channel-release
by Holger Hans Peter Freyther 17 Dec '12

17 Dec '12

Hi, I have rebased, extended and fixed the channel assignment and release. It brings us closer to the GSM 04.08 specification but there are still sime minor violations for the abnormal handling. I have tested (using the FakeBTS) a phone not acting on the SACCH deactivate/RF Channel Release and the signalling link will be released (T3109). I have a manual SMS submit test and I can make the nanoBTS crash easily. I have rebased through each individual change and couldn't reproduce the crash. I think it is either something in the RF setup (the modem bank being too close to the BTS), the older modem firmware, etc. Anyway, please review and test the branch. I plan to merge it by Wednesday. thanks holger

1 0

Anybody else getting openbsc segfaults on IMSI Detach?
by Tobias Engel 15 Dec '12

15 Dec '12

Hi, I pulled a newer openbsc version today for the first time in several months. Now, when a phone sends an IMSI Detach, osmo-nitb segfaults. The reason seems to be: osmo_msc.c:msc_compl_l3 gets called from gsm0408_rcvmsg, which in turn calls gsm0408_dispatch which at some point ends up in gsm48_rx_mm_imsi_detach_ind, which calls msc_release_connection, which calls gsm0808_clear, which sets conn->bts = NULL. Now, back in msc_compl_l3, trans_has_conn is called, which tries to dereference conn->bts->network, which causes the segfault. It might have been introduced with Holger's patch "msc: Attempt to release the lchan immediately on IMSI Detach" (153b13b0), but that was already in July... -Tobias

2 3

GANC
by Raymond Chiu 10 Dec '12

10 Dec '12

I was Googling open source GANC and came across you web page: http://openbsc.osmocom.org/trac/wiki/osmo-ganc I am interested in learning how to program handsets to work with a GANC controller. Because I am new at this, I am not sure if it is possible to add this functionality to an existing platform and would like to learn more about existing implementations. Is there a good resource (code examples) to look view? Thank you. Raymond SMS: (703)828-7168 raymond.m.chiu.(a)gmail.com

1 0

[PATCH 0/3] libosmo-crypt-a53 autotools cleanup
by Alexander Huemer 09 Dec '12

09 Dec '12

This a series of 3 patches for libosmo-crypt-a53, branch master. Former HEAD was 3de78cd69c0594b0903e6cfffab7920c69e2d478. The patches clean up the autotools configuration. The library itself is not changed[1]. Fell free to merge the patches if they seem useful. Kind regards, -Alexander Huemer [1] overall diffstat: configure.ac | 2 +- m4/DUMMY | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)

2 4

Re: OpenBSC + LCR + Asterisk
by Andreas Eversberg 09 Dec '12

09 Dec '12

[ast] remote asterisk context from-lcr earlyb yes tones yes hi pierre, the chan_lcr to asterisk is now an interface. you can define multiple interfaces, if you like to use different contexts. (in this case it is "from-lcr".) exten => _.,1,Dial(LCR/ast/${EXTEN:0}) in order to define what interface to be used, name it in the dial app at extensions.conf. ("ast" in this case.) regards, andreas

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC