OpenBSC

openbsc@lists.osmocom.org

4 participants
4156 discussions

[PATCH 2/2] gprs_llc: Assert that we send frames with either tlli or old_tlli

by Holger Hans Peter Freyther

In case we have access to the context verify that the selected msgb_tlli is either the old_tlli or the tlli. It is wrong to use any other TLLI. --- openbsc/src/gprs/gprs_llc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/openbsc/src/gprs/gprs_llc.c b/openbsc/src/gprs/gprs_llc.c index 57e557a..c3bd9d2 100644 --- a/openbsc/src/gprs/gprs_llc.c +++ b/openbsc/src/gprs/gprs_llc.c @@ -52,6 +52,10 @@ static int _bssgp_tx_dl_ud(struct msgb *msg, struct sgsn_mm_ctx *mmctx) dup.drx_parms = mmctx->drx_parms; dup.ms_ra_cap.len = mmctx->ms_radio_access_capa.len; dup.ms_ra_cap.v = mmctx->ms_radio_access_capa.buf; + + /* make sure we only send it to the right llme */ + OSMO_ASSERT(msgb_tlli(msg) == mmctx->llme->tlli + || msgb_tlli(msg) == mmctx->llme->old_tlli); } memcpy(&dup.qos_profile, qos_profile_default, sizeof(qos_profile_default)); -- 1.8.3.2 --UugvWAfsgieZRqgk--

11 years, 11 months

7 patches

by Andreas Eversberg

hi, these 7 patches have been tested with sysmobts and osmo-bts (trx interface). it works with calls and gprs. before applying any of these patches, i suggest to double check it with a different test setup. regards, andreas

11 years, 11 months

[PATCH 1/2] gprs_llc: Lookup lle based on the real TLLI

by Holger Hans Peter Freyther

During the GPRS Attach procedure we might have a foreign tlli and in the RX create a LLME on the fly for this tlli. The GMM GPRS Attach handling code will then assign a new TLLI and keep the foreign tlli as the llme->old_tlli. When the GMM is sending the identity request the msgb_tlli will point to the foreign tlli. The GPRS LLC code will then try to find that foreign tlli but due the conversion this will not be found. Instead a new ad-hoc LLE/LLME will be created on the fly for each message (this means there are duplicate LLE/LLMEs in the list). Make the code more strict and remove the tlli_foreign2local change from the look-up routine. This will make the GPRS LLC code find the right LLE/LLME and the N(U) will be handled correctly. Addresses: <0012> gprs_llc.c:773 LLC RX: unknown TLLI 0xadf11820, creating LLME on the fly ... <0012> gprs_llc.c:357 LLC TX: unknown TLLI 0xedf11820, creating LLME on the fly Reproducable: Use pcu_emu (gprs attach) and observe with wireshark. --- openbsc/src/gprs/gprs_llc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/openbsc/src/gprs/gprs_llc.c b/openbsc/src/gprs/gprs_llc.c index 8af5367..57e557a 100644 --- a/openbsc/src/gprs/gprs_llc.c +++ b/openbsc/src/gprs/gprs_llc.c @@ -147,12 +147,10 @@ static inline uint32_t tlli_foreign2local(uint32_t tlli) } /* lookup LLC Entity based on DLCI (TLLI+SAPI tuple) */ -static struct gprs_llc_lle *lle_by_tlli_sapi(uint32_t tlli, uint8_t sapi) +static struct gprs_llc_lle *lle_by_tlli_sapi(const uint32_t tlli, uint8_t sapi) { struct gprs_llc_llme *llme; - tlli = tlli_foreign2local(tlli); - llist_for_each_entry(llme, &gprs_llc_llmes, list) { if (llme->tlli == tlli || llme->old_tlli == tlli) return &llme->lle[sapi]; -- 1.8.3.2 --UugvWAfsgieZRqgk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-gprs_llc-Assert-that-we-send-frames-with-either-tlli.patch"

11 years, 11 months

[PATCH] Add vty command for setting Access control classes

by Ivan Kluchnikov

Hi all, Attached patch adds vty command for setting Access control classes (GSM 02.11 Section 4 Access control) in RACH Control Parameters (GSM 04.08 Section 10.5.2.29 RACH Control Parameters). -- Regards, Ivan Kluchnikov. http://fairwaves.ru

11 years, 11 months

Nokia InSite handover

by Sipos Csaba

Today, after I successfully started two InSite BTS units on the same E1 line, I tried to test the OpenBSC handover function. I got a strange error message, that I have to enable RTP Proxy mode with "-P" in osmo-nitb. Because these units are running from E1, I just simply ask: do we have handover support for E1 based BTSs? Cell reselection and inter BTS voice calls, SMSs are working just fine. BR, Csaba

11 years, 11 months

GPRS roaming

by Andreas Eversberg

hi harald, i know that you talked about before so maybe you can give me a hint. i like to make osmo-sgsn allow roaming (different PLMN of the phone than the one in the RAI of the BTS). regards, andreas

11 years, 11 months

Dropping support for the HSL bts

by Holger Hans Peter Freyther

Good Morning Harald, do you mind if we drop support for the HSL BTS? The support is spewing out compile warnings, now turns up in coverity reports as well and we don't even know if it is working with the latest version of the software running on these BTS. holger

11 years, 11 months

Any BS11 user please test the following patch

by Holger Hans Peter Freyther

Hi, Coverity pointed out a missing break. I have added it now but the fix might break BS11 code that relied on this broken functionality. Could anyone with a BS11 please test this? I will integrate the change in a week. holger

11 years, 11 months

DAHDI and LAPd errors

by Sipos Csaba

Dear Members, From the beginning I am having various LAPd related error messages with Nokia InSite and a DAHDI E1 card. The LAPd connection resets itself several times before a working OML and RSL connection is made. I don't know, maybe this is due to a change in the DAHDI code. I am getting lapd errors during the BTS initialization like this one: ^[[0;m^[[1;36mTue Jul 16 13:55:10 2013 <0005> bsc_init.c:91 shutting down OML for BTS 0 ^[[0;mTue Jul 16 13:55:14 2013 <0018> input/lapd.c:159 LAPD state change on TEI 1: NONE -> ASSIGNED ^[[0;mTue Jul 16 13:55:14 2013 <0018> input/lapd.c:212 LAPD Allocating SAP for SAPI=62 / TEI=1 ^[[0;mTue Jul 16 13:55:14 2013 <0018> input/lapd.c:223 k=1 N200=3 N201=260 T200=1.0 T203=10.0 ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:292 Init DL layer: sequence range = 128, k = 1, history range = 2 ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:229 new state LAPD_STATE_NULL -> LAPD_STATE_IDLE ^[[0;mTue Jul 16 13:55:14 2013 <0018> input/lapd.c:485 LAPD DL-ESTABLISH request TEI=1 SAPI=62 ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:2171 Message DL-ESTABLISH-REQUEST received in state LAPD_STATE_IDLE ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:1685 perform normal establishm. (SABM) ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:229 new state LAPD_STATE_IDLE -> LAPD_STATE_SABM_SENT ^[[0;mTue Jul 16 13:55:14 2013 <0018> input/lapd.c:600 TX: fa 03 7f ^[[0;mTue Jul 16 13:55:14 2013 <0018> lapd_core.c:198 start T200 ^[[0;m^[[1;38mTue Jul 16 13:55:14 2013 <001d> sms_queue.c:220 Attempting to send 20 SMS ^[[0;m^[[1;38mTue Jul 16 13:55:14 2013 <001d> sms_queue.c:280 SMSqueue added 0 messages in 0 rounds ^[[0;mTue Jul 16 13:55:15 2013 <0018> lapd_core.c:551 Timeout T200 (0x822cb80) state=5 ^[[0;mTue Jul 16 13:55:15 2013 <0018> input/lapd.c:600 TX: fa 03 7f ^[[0;mTue Jul 16 13:55:15 2013 <0018> lapd_core.c:198 start T200 ^[[0;mTue Jul 16 13:55:16 2013 <0018> lapd_core.c:551 Timeout T200 (0x822cb80) state=5 ^[[0;mTue Jul 16 13:55:16 2013 <0018> input/lapd.c:600 TX: fa 03 7f ^[[0;mTue Jul 16 13:55:16 2013 <0018> lapd_core.c:198 start T200 ^[[0;mTue Jul 16 13:55:17 2013 <0018> lapd_core.c:551 Timeout T200 (0x822cb80) state=5 ^[[0;mTue Jul 16 13:55:17 2013 <0018> input/lapd.c:600 TX: fa 03 7f ^[[0;mTue Jul 16 13:55:17 2013 <0018> lapd_core.c:198 start T200 ^[[0;mTue Jul 16 13:55:18 2013 <0018> lapd_core.c:551 Timeout T200 (0x822cb80) state=5 ^[[0;mTue Jul 16 13:55:18 2013 <0018> input/lapd.c:628 LAPD DL-RELEASE indication TEI=1 SAPI=62 ^[[0;mTue Jul 16 13:55:18 2013 <0018> lapd_core.c:307 Resetting LAPDm instance ^[[0;mTue Jul 16 13:55:18 2013 <0018> lapd_core.c:229 new state LAPD_STATE_SABM_SENT -> LAPD_STATE_IDLE ^[[0;mTue Jul 16 13:55:18 2013 <0018> lapd_core.c:384 sending MDL-ERROR-IND cause 1 ^[[0;mTue Jul 16 13:55:18 2013 <0018> lapd_core.c:229 new state LAPD_STATE_IDLE -> LAPD_STATE_IDLE ^[[0;m^[[1;36mTue Jul 16 13:55:33 2013 <0005> bsc_init.c:91 shutting down OML for BTS 0 Anyway, it would be nice to know a recommended DAHDI version and/or kernel version which is used during the development or something. For example - as I mentioned it earlier - DAHDI 2.7.x breaks the compatibility with OpenBSC due to the changed addressing scheme. BR, Csaba

11 years, 12 months

Fixing power off in osmo-trx

by Alexander Chemeris

Hi Thomas, I've made some progress in making osmo-trx able to power off/on without restart. At this moment it's almost there - the only big remaining issue I see is some bug with UHD device start/stop. It seems we do not re-initialize it properly and assert (num_rd == OUTCHUNK) fails. I hope you could fix that. I completely re-wrote Thread class to make starting/stopping threads a synchronous reliable operation. I also introduced shutdown() function to FIFOServiceLoopThread, ControlServiceLoopThread and TransmitPriorityQueueServiceLoopThread. This method takes care of un-blocking a thread from a blocking read from a queue or a socket. Few bugs in the other code is fixed as well. Details are below, please review the patches. Patch set is checked into https://github.com/fairwaves/osmo-trx under achemeris/stable_threads and achemeris/poweroff_hack branches. > commit c5da6607b4d17706380de72e0814e28f03624c51 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 14:57:14 2013 +0400 > > Transceiver52M: Fix crash in uhd_device destructor due to deleting statically allocated memory. This is a genuine bug, should be fixed upstream. > commit dbd27a60b6ed99fd6fd2339ffafccc0d759fa2fc > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sat Jul 13 21:26:39 2013 +0400 > > CommonLibs: Fix compile time warnings. Fixes annoying warning. > commit 8eaa40dd6c2a783306d809aec98c2937e15068f3 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 16:23:32 2013 +0400 > > Transceiver52M: Remove unused thread mAlignRadioServiceLoopThread; This actually leads to crash when Thread class is abstract. > commit b8646946526903d2bbfa657690936b9bcba80ca5 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sat Jul 13 22:29:12 2013 +0400 > > CommonLibs: DEBUG: Mark interthread classes which are not used in OsmoTRX. I've added this comments just to simplify debugging. I.e. I don't want to debug interthread primitives which we do not use. > commit 69b6a6dfcd882df180e9d5e9856225f4b1d2eeed > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 01:43:04 2013 +0400 > > CommonLibs: Allow NULLs to be retrieved from InterthreadQueue. > > We need a way to stop InterthreadQueue blocking read to be able to shutdown > a thread. The easiest way to do that is to push NULL to the queue, but the > original implementation will just ignore that and continue blocking. After > the change the blocking read() will exit with NULL result which is perfectly > fine with us. > > Ideally we should change all methods of InterthreadQueue to return a status > value to indicate normal exits, timeouts, etc. Right now the only way to > indicate an error is returning NULL, which could be a valid operation. > > commit d4a8c1360e5d54188b648766dde199fa37f2ed27 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 02:00:00 2013 +0400 > > CommonLibs: Add shutdown() method to the DatagramSocket class. > > This method is useful to abort a blocking operations on a socket during shutdown. > > commit 302a9198df85e4f771368f24d8445dec7c8b2203 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 12:04:44 2013 +0400 > > CommonLibs: Signal::wait() should return the value which pthread_cond_timedwait() returns. > > commit e279124660a2add686e6c9266d18a9bb0cf43258 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 12:38:25 2013 +0400 > > CommonLibs: Rewrite Threads class to be predictable during start/stop. > > Current implementation strictly synchronize thread startup and shutdown > to make sure a thread is actually started on startThread() exit and > that it's stopped on stopThread() exit (or an error is returned). > > I also changed the Thread class to be used as a parent class for > an actual thread. This way we could provide much better logical > separation between variables used by different threads. Which will > (hopefully) reduce number of issues with inter-thread communications. > > commit de202e343564913e0591de10850e617d7de55b6b > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 12:42:52 2013 +0400 > > Transceiver52M: Port all threads to the new Thread interface. > > Also note that we introduced shutdown() method for Transceiver threads which > implement proper shutdown of threads when they are in blocking read state. > This involves using shutdown() on sockets and pushing NULL to queues. > > With this change we should be able to start/stop transceiver channels at > arbitrary moments. > > commit 129ad76b15f1fdf0588d5a24fe2d0f7ef3df274e > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 12:48:37 2013 +0400 > > Transceiver52M: Delay is no longer needed at the transceiver exit, threads should shut down cleanly. > > commit 604f65e69f2317dd5dc1aeb8faf3c107cd8a2231 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 13:22:31 2013 +0400 > > CommonLibs: Port InterthreadTest and SocketsTest to the new Thread API. > > commit c4038ef54c806c8c00f7fa28bc2b8b200bc3356f > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 13:24:16 2013 +0400 > > CommonLibs: Adding a new ThreadsTest testsuite. > > It's very basic at this moment. We should add a stress-test for thread > start/stop at least. This is the meat of the branch. At this stage everything works fine, threads are shutdown properly, but power off command still doesn't power off the transceiver. > commit c0f0da4ec8e0068a562f427a89a899bf190bc74a > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 23:07:31 2013 +0400 > > Transceiver52M: HACK: Exit transceiver on POWEROFF command. > > This hack allows OsmoBTS to correctly restart itself with different parameters. > We assume that transceiver is run as a service and will be restarted on exit. > > commit 806a64b1df40871543e9ae34386463d08a564147 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 22:58:55 2013 +0400 > > Transceiver52M: Start and stop all threads on POWERON/POWEROFF. > > This change reveals some issue with the UHD start/stop code. Specifically, > we get a failed assert in RadioInterface::pullBuffer() (num_rd == OUTCHUNK > with num_rd=0) with the POWERON/POWEROFF/POWERON sequence. These patches implements actual power off command. They are split into a separate branch, because they lead to assert failure I mentioned above. In my setup it's 100% reproducible. I hope you could fix that. > commit 4c39dd4b492b439742911aa70623d41ad634d7f4 > Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> > Date: Sun Jul 14 22:45:40 2013 +0400 > > Transceiver52M: Introduce usage counting for DriveLoop and RadioInterface. > > The reason is to allow them to be started from any TRX. I.e. they are started > when the first TRX starts and stopped when the last TRX stops. This hack is a workaround for the assert failure above - it shuts down the complete transceiver in a hope that it will be restarted by external means. Meant as to be used in production while we don't have the assert failure fixed. -- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru

11 years, 12 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC